Attachment 137949 Details for Bug 30458 – Bug 30458: Include librarian (manager_id) in accountline when using "Payout amount" button

[patch] Bug 30458: Include librarian (manager_id) in accountline when using "Payout amount" button

Bug-30458-Include-librarian-managerid-in-accountli.patch (text/plain), 1.62 KB, created by Joonas Kylmälä on 2022-07-20 18:33:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2022-07-20 18:33:21 UTC

Size: 1.62 KB

patch

obsolete

>From c75ebd430cd319b373906af9f1cb9de07faf2d6e Mon Sep 17 00:00:00 2001
>From: Kyle Hall <kyle@bywatersolutions.com>
>Date: Tue, 5 Apr 2022 09:40:51 -0400
>Subject: [PATCH] Bug 30458: Include librarian (manager_id) in accountline when
> using "Payout amount" button
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>When using the "Payout amount" button, accountlines.manager_id is not
>populated. This is not the case with the "Issue payout" buttons.
>
>Test Plan:
>1) Create a manual credit
>2) Issue a payout using the "Payout amount" button
>3) Inspect the payout accountline, note it has no manager_id
>4) Apply this patch, restart all the things!
>5) Repeat steps 1 and 2
>6) Note the new payout accountline has a manager_id!
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>JK: Fix commit title
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> Koha/Account.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Account.pm b/Koha/Account.pm
>index ad5d5c6040..4c13a9a07e 100644
>--- a/Koha/Account.pm
>+++ b/Koha/Account.pm
>@@ -606,7 +606,7 @@ sub payout_amount {
>                     type              => 'PAYOUT',
>                     transaction_type  => $params->{payout_type},
>                     amountoutstanding => $params->{amount},
>-                    manager_id        => $params->{staff_id},
>+                    user_id           => $params->{staff_id},
>                     interface         => $params->{interface},
>                     branchcode        => $params->{branch},
>                     cash_register     => $params->{cash_register}
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30458: 132976 | 137905 | 137949