Attachment 137986 Details for Bug 30471 – Bug 30471: Correct display of default rules

[patch] Bug 30471: Correct display of default rules

Bug-30471-Correct-display-of-default-rules.patch (text/plain), 2.44 KB, created by Joonas Kylmälä on 2022-07-21 16:04:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2022-07-21 16:04:48 UTC

Size: 2.44 KB

patch

obsolete

>From 5623802e28956d855bf8d90bda3ad2880bd96f69 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 6 Apr 2022 13:49:58 +0000
>Subject: [PATCH] Bug 30471: Correct display of default rules
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To test:
>1 - Browse to 'Administration->Circulation and fines rules'
>2 - Make sure you are editing 'Standard rules for all libraries'
>3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine'
>4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)'
>5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine'
>6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)'
>7 - Apply patch and repeat, note the default descriptions now display correctly
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 249cec02dc..1e8bc8907e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -1017,9 +1017,9 @@
> [% IF defaultRefundRule == 'refund' %]
> Use default (Refund lost item charge)
> [% ELSIF defaultRefundRule == 'charge' %]
>- Use default (Refund lost item charge and restore overdue fine)
>- [% ELSIF defaultRefundRule == 'restore' %]
> Use default (Refund lost item charge and charge new overdue fine)
>+ [% ELSIF defaultRefundRule == 'restore' %]
>+ Use default (Refund lost item charge and restore overdue fine)
> [% ELSE %]
> Use default (Leave lost item charge)
> [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30471: 133028 | 137958 | 137959 | 137986