Attachment 137992 Details for Bug 29001 – Bug 29001: (QA follow-up) Remove code duplication

[patch] Bug 29001: (QA follow-up) Remove code duplication

Bug-29001-QA-follow-up-Remove-code-duplication.patch (text/plain), 2.85 KB, created by Joonas Kylmälä on 2022-07-21 18:03:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2022-07-21 18:03:53 UTC

Size: 2.85 KB

patch

obsolete

>From 456ebe1fe2703eb4bd76acf42e89e6f1a1847ba6 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Thu, 21 Jul 2022 17:57:20 +0000
>Subject: [PATCH] Bug 29001: (QA follow-up) Remove code duplication
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> .../prog/en/modules/admin/marc_subfields_structure.tt          | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>index acaceaef34..4120897921 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>@@ -154,6 +154,7 @@
> 
>                                     [% FOREACH loo IN loop %]
>                                         <div class="constraints tab-pane" role="tabpanel" id="sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field">
>+                                            <input type="hidden" name="tab_id" value="[% loo.row | html %]" />
>                                             <div id="basic[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]" class="contraints">
>                                                 <fieldset class="rows">
>                                                     <legend>Basic constraints</legend>
>@@ -163,13 +164,11 @@
>                                                                 <span class="label">Subfield code:</span>
>                                                                 [% loo.subfieldcode | html %]
>                                                                 <input type="hidden" name="tagsubfield" value="[% loo.subfieldcode | html %]" />
>-                                                                <input type="hidden" name="tab_id" value="[% loo.row | html %]" />
>                                                             </li>
>                                                         [% ELSE %]
>                                                             <li>
>                                                                 <label for="tagsubfield[% loo.row | html %]">Subfield code:</label>
>                                                                     <input type="text" id="tagsubfield[% loo.row | html %]" name="tagsubfield" value="[% loo.subfieldcode | html %]" />
>-                                                                    <input type="hidden" name="tab_id" value="[% loo.row | html %]" />
>                                                                 </li>
>                                                         [% END %]
>                                                         <li>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29001: 137874 | 137893 | 137904 | 137991 | 137992