Attachment 138065 Details for Bug 29434 – Bug 29434: add UNIMARC relationship codes for authorities

[patch] Bug 29434: add UNIMARC relationship codes for authorities

Bug-29434-add-UNIMARC-relationship-codes-for-autho.patch (text/plain), 5.48 KB, created by David Nind on 2022-07-23 22:51:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-07-23 22:51:29 UTC

Size: 5.48 KB

patch

obsolete

>From ebb1eacad54a2fc7fc954ecf93a741a7d56eeb5a Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <a.roussos@dataly.gr>
>Date: Mon, 8 Nov 2021 08:19:58 +0100
>Subject: [PATCH] Bug 29434: add UNIMARC relationship codes for authorities
>
>When using the authority finder plugin (authorities/auth_finder.pl),
>you can pick an entry from the 'Special relationship:' dropdown menu
>in order to set the relationship between authorities.
>
>However, in UNIMARC instances the relationship codes listed are those
>for MARC21. The correct codes for UNIMARC are listed in pages 93-94
>of the IFLA UNIMARC Manual for Authorities.
>
>Test plan:
>
>1) In a UNIMARC instance, launch authorities/auth_finder.pl in the
>   Staff client, by clicking on the 'Tag editor' button. Notice how
>   the 'Special relationship:' dropdown menu lists the relationship
>   codes for MARC21 instead of UNIMARC.
>2) Apply this patch.
>3) Launch the authority finder again; this time the correct values
>   should be listed in the 'Special relationship:' dropdown menu.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/includes/auth-finder-search.inc   | 41 ++++++++++++++-----
> 1 file changed, 31 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc
>index 9453e3f40b..4f742e2b92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc
>@@ -1,3 +1,4 @@
>+[% USE Koha %]
> [% PROCESS 'form-blocks.inc' %]
> 
> <div id="toolbar" class="btn-toolbar">
>@@ -143,16 +144,36 @@
>                 <select name="relationship" id="relationship">
>                     [% selected=relationship | html %]
>                     [% PROCESS selectoptionopen value='' %]None specified</option>
>-                    [% PROCESS selectoptionopen value='a' %]a - Earlier heading</option>
>-                    [% PROCESS selectoptionopen value='b' %]b - Later heading</option>
>-                    [% PROCESS selectoptionopen value='d' %]d - Acronym</option>
>-                    [% PROCESS selectoptionopen value='f' %]f - Musical composition</option>
>-                    [% PROCESS selectoptionopen value='g' %]g - Broader term</option>
>-                    [% PROCESS selectoptionopen value='h' %]h - Narrower term</option>
>-                    [% PROCESS selectoptionopen value='i' %]i - Reference instruction phrase in subfield $i</option>
>-                    [% PROCESS selectoptionopen value='n' %]n - Not applicable</option>
>-                    [% PROCESS selectoptionopen value='r' %]r - Relationship designation in $i or $4</option>
>-                    [% PROCESS selectoptionopen value='t' %]t - Immediate parent body</option>
>+                    [% IF Koha.Preference('marcflavour') == 'MARC21' %]
>+                      [% PROCESS selectoptionopen value='a' %]a - Earlier heading</option>
>+                      [% PROCESS selectoptionopen value='b' %]b - Later heading</option>
>+                      [% PROCESS selectoptionopen value='d' %]d - Acronym</option>
>+                      [% PROCESS selectoptionopen value='f' %]f - Musical composition</option>
>+                      [% PROCESS selectoptionopen value='g' %]g - Broader term</option>
>+                      [% PROCESS selectoptionopen value='h' %]h - Narrower term</option>
>+                      [% PROCESS selectoptionopen value='i' %]i - Reference instruction phrase in subfield $i</option>
>+                      [% PROCESS selectoptionopen value='n' %]n - Not applicable</option>
>+                      [% PROCESS selectoptionopen value='r' %]r - Relationship designation in $i or $4</option>
>+                      [% PROCESS selectoptionopen value='t' %]t - Immediate parent body</option>
>+                    [% ELSIF Koha.Preference('marcflavour') == 'UNIMARC' %]
>+                      [% PROCESS selectoptionopen value='a' %]a = earlier name</option>
>+                      [% PROCESS selectoptionopen value='b' %]b = later name</option>
>+                      [% PROCESS selectoptionopen value='c' %]c = official name</option>
>+                      [% PROCESS selectoptionopen value='d' %]d = acronym / initial / abbreviation</option>
>+                      [% PROCESS selectoptionopen value='e' %]e = pseudonym</option>
>+                      [% PROCESS selectoptionopen value='f' %]f = real name</option>
>+                      [% PROCESS selectoptionopen value='g' %]g = broader term or name</option>
>+                      [% PROCESS selectoptionopen value='h' %]h = narrower term or name</option>
>+                      [% PROCESS selectoptionopen value='i' %]i = name in religion</option>
>+                      [% PROCESS selectoptionopen value='j' %]j = married name</option>
>+                      [% PROCESS selectoptionopen value='k' %]k = name before marriage</option>
>+                      [% PROCESS selectoptionopen value='l' %]l = shared pseudonym</option>
>+                      [% PROCESS selectoptionopen value='m' %]m = secular name</option>
>+                      [% PROCESS selectoptionopen value='n' %]n = different rule form of a name</option>
>+                      [% PROCESS selectoptionopen value='o' %]o = attributed name / conventional title of a work</option>
>+                      [% PROCESS selectoptionopen value='x' %]x = not applicable</option>
>+                      [% PROCESS selectoptionopen value='z' %]z = other</option>
>+                    [% END %]
>                 </select>
>             </li>
>             </ol>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29434: 127420 | 127421 | 127422 | 127423 | 127424 | 138065 | 138885