Attachment 138067 Details for Bug 26549 – Bug 26549: Show value of global system preferences on subscription form

[patch] Bug 26549: Show value of global system preferences on subscription form

Bug-26549-Show-value-of-global-system-preferences-.patch (text/plain), 4.78 KB, created by Katrin Fischer on 2022-07-24 22:05:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-07-24 22:05:14 UTC

Size: 4.78 KB

patch

obsolete

>From 4b1559f65103e5893b219597fae3710c83f9f893 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 12 May 2022 15:53:55 +0000
>Subject: [PATCH] Bug 26549: Show value of global system preferences on
> subscription form
>
>This patch modifies the subscription entry form so that the values of
>two system preferences are displayed as a hint to the user:
>
>The "Number of issues to display to staff" field will show the value
>of the StaffSerialIssueDisplayCount preference, and the "Number of
>issues to display to the public" field will show
>OPACSerialIssueDisplayCount. If the user has permission the system
>preference names will link to the system preferences page.
>
>To test, apply the patch and log into the staff interface as a user with
>permission to edit system preferences.
>
>- Go to Serials -> New subscription.
>- The "Number of issues to display to staff" field should have a hint
>  under it: "Default: XX (StaffSerialIssueDisplayCount system
>   preference)"
>- The "Number of issues to display to the public" field should have a
>  hint under it: "Default: XX (OPACSerialIssueDisplayCount system
>  preference)"
>- Log out and log back in as a user who does not have permission to edit
>  system preferences. Return to the form and confirm that the hints do
>  not link to system preferences.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../en/modules/serials/subscription-add.tt    | 20 ++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>index f8b908858d..5c1e8ac1a9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>@@ -248,17 +248,35 @@ fieldset.rows table { clear: none; margin: 0; }
>                                     </select>
>                                 </li>
>                                 [% END %]
>-                                    <li>
>+                                <li>
>                                     <label for="graceperiod">Grace period:</label>
>                                     <input type="text" name="graceperiod" id="graceperiod" value="[% graceperiod | html %]" size="5"/> day(s)
>                                 </li>
>                                 <li>
>                                      <label class="widelabel" for="staffdisplaycount">Number of issues to display to staff: </label>
>                                      <input type="text" name="staffdisplaycount" id="staffdisplaycount" value="[% staffdisplaycount | html %]" inputmode="numeric" pattern="[0-9]*"  size="4"/>
>+                                     <div class="hint">
>+                                        Default:
>+                                        [% Koha.Preference('StaffSerialIssueDisplayCount') | html %]
>+                                        [% IF ( CAN_user_parameters_manage_sysprefs ) %]
>+                                            (<a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=StaffSerialIssueDisplayCount">StaffSerialIssueDisplayCount</a> system preference)
>+                                        [% ELSE %]
>+                                            (StaffSerialIssueDisplayCount system preference)
>+                                        [% END %]
>+                                    </div>
>                                  </li>
>                                  <li>
>                                     <label class="widelabel" for="opacdisplaycount">Number of issues to display to the public: </label>
>                                     <input type="text" name="opacdisplaycount" id="opacdisplaycount" value="[% opacdisplaycount | html %]" inputmode="numeric" pattern="[0-9]*"  size="4"/>
>+                                    <div class="hint">
>+                                        Default:
>+                                        [% Koha.Preference('OPACSerialIssueDisplayCount') | html %]
>+                                        [% IF ( CAN_user_parameters_manage_sysprefs ) %]
>+                                            (<a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=OPACSerialIssueDisplayCount">OPACSerialIssueDisplayCount</a>  system preference)
>+                                        [% ELSE %]
>+                                            (OPACSerialIssueDisplayCount system preference)
>+                                        [% END %]
>+                                    </div>
>                                 </li>
>                             </ol>
>                         </fieldset>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 26549: 134937 | 134940 | 135110 | 138067