Attachment 13808 Details for Bug 9135 – [SIGNED-OFF] Bug 9135: updatedatabase.pl fails when DEBUG is set

[patch] [SIGNED-OFF] Bug 9135: updatedatabase.pl fails when DEBUG is set

SIGNED-OFF-Bug-9135-updatedatabasepl-fails-when-DE.patch (text/plain), 1.34 KB, created by Katrin Fischer on 2012-12-01 20:07:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2012-12-01 20:07:58 UTC

Size: 1.34 KB

patch

obsolete

>From af196df72c2eae49bab3e1083f49f6a659cd8eb0 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Fri, 23 Nov 2012 12:30:26 -0500
>Subject: [PATCH] [SIGNED-OFF] Bug 9135: updatedatabase.pl fails when DEBUG is
> set
>
>When the DEBUG environment variable is set to a true value, all DBI
>errors are treated as fatal. Unfortunately, duplicate keys are
>incredibly common in updatedatabase.pl, since sysprefs are often added
>in testing, then re-added once the patches have been pushed to master
>(or added when on a maintenance branch, and then re-added when the
>system is upgraded to either a newer maintenance branch or master).
>This patch disables fatal errors for the updatedatabase.pl script.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>All tests and perlcritic pass.
>To test, run from command line:
>export DEBUG=1
>installer/data/mysql/updatedatabase.pl
>---
> installer/data/mysql/updatedatabase.pl |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index f24d8b4..a6af263 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -64,6 +64,7 @@ GetOptions(
> my $dbh = C4::Context->dbh;
> $|=1; # flushes output
> 
>+local $dbh->{RaiseError} = 0;
> 
> # Record the version we are coming from
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9135: 13652 | 13808 | 13837