Attachment 138106 Details for Bug 21982 – Bug 21982: Circulation statistics wizard does not count deleted items

[patch] Bug 21982: Circulation statistics wizard does not count deleted items

Bug-21982-Circulation-statistics-wizard-does-not-c.patch (text/plain), 1.64 KB, created by Katrin Fischer on 2022-07-25 22:09:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-07-25 22:09:28 UTC

Size: 1.64 KB

patch

obsolete

>From 3bab708591aa1d1e5b01a4d6481cb3df897f4076 Mon Sep 17 00:00:00 2001
>From: jeremy breuillard <jeremy.breuillard@biblibre.com>
>Date: Wed, 24 Nov 2021 16:56:09 +0100
>Subject: [PATCH] Bug 21982: Circulation statistics wizard does not count
> deleted items
>
>By default statistic assistant filter is set on the
>existing items and doesn't mind about deleted items.
>The patch corrects this. Items belong to the same library.
>
>Test plan:
>1)Make sure to have at least 1 or more item(s) in deleteditems database table
>2)Home > Reports > Circulation statistics
>3)Fill up 'Issuing library', 'Home library' and 'Holding library'
>4)Submit
>5)Notice that only statistics for active items are shown
>6)Apply patch and repeat from 2) to 5)
>7)Now active items and deleted items are shown
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> reports/issues_stats.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl
>index ca0b8ec100..6b541f7b28 100755
>--- a/reports/issues_stats.pl
>+++ b/reports/issues_stats.pl
>@@ -506,7 +506,7 @@ sub calculate {
>             $strcalc .= " LEFT JOIN borrower_attributes AS attribute_$_ ON (statistics.borrowernumber = attribute_$_.borrowernumber AND attribute_$_.code = '$_') ";
>         }
>     }
>-    $strcalc .= "LEFT JOIN items ON statistics.itemnumber=items.itemnumber "
>+    $strcalc .= "LEFT JOIN (SELECT * FROM items UNION SELECT * FROM deleteditems) items ON statistics.itemnumber=items.itemnumber "
>       if ( $linefield =~ /^items\./
>         or $colfield =~ /^items\./
>         or $process == 5
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 21982: 128011 | 128012 | 128013 | 128026 | 138075 | 138106