Attachment 138127 Details for Bug 31223 – Bug 31223: Do not explode if plugins disabled

[patch] Bug 31223: Do not explode if plugins disabled

Bug-31223-Do-not-explode-if-plugins-disabled.patch (text/plain), 1.30 KB, created by Tomás Cohen Arazi (tcohen) on 2022-07-26 13:00:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-07-26 13:00:52 UTC

Size: 1.30 KB

patch

obsolete

>From 07c48cf752ceb9a1d060320280eb2635b7f371aa Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 26 Jul 2022 09:55:38 -0300
>Subject: [PATCH] Bug 31223: Do not explode if plugins disabled
>
>This patch makes the code skip calculating the plugin-related task
>codes => class mapping if plugins are entirely disbaled.
>
>To test:
>1. Apply the regression tests
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/Koha/BackgroundJob.t
>=> FAIL: Tests explode with: Can't call method "GetPlugins" on an
>undefined value at... Koha/BackgroundJob.pm line 424.
>3. Apply this patch
>4. Repeat 2
>=> SUCCESS: Tests pass!
>5. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/BackgroundJob.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm
>index 76bed24426a..dcfba14659d 100644
>--- a/Koha/BackgroundJob.pm
>+++ b/Koha/BackgroundJob.pm
>@@ -380,7 +380,7 @@ Returns the available types to class mappings.
> sub type_to_class_mapping {
>     my ($self) = @_;
> 
>-    my $plugins_mapping = $self->plugin_types_to_classes;
>+    my $plugins_mapping = ( C4::Context->config("enable_plugins") ) ? $self->plugin_types_to_classes : {};
> 
>     return ($plugins_mapping)
>       ? { %{ $self->core_types_to_classes }, %$plugins_mapping }
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 31223: 138126 | 138127 | 138128 | 138129 | 138130 | 138131 | 138142 | 138143 | 138144 | 138390 | 138391