Attachment 138148 Details for Bug 31244 – Bug 31244: Fix 500 if logout and not logged in

[patch] Bug 31244: Fix 500 if logout and not logged in

Bug-31244-Fix-500-if-logout-and-not-logged-in.patch (text/plain), 1.31 KB, created by ByWater Sandboxes on 2022-07-27 07:24:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2022-07-27 07:24:02 UTC

Size: 1.31 KB

patch

obsolete

>From f785fc4712648a53e3ff12c278b8b6a49e94f163 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 26 Jul 2022 14:55:02 +0200
>Subject: [PATCH] Bug 31244: Fix 500 if logout and not logged in
>
>Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm line 985
>        C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0, 'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at /kohadevbox/koha/C4/Auth.pm line 186
>        C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at /kohadevbox/koha/mainpage.pl line 40
>
>Test plan:
>Open a private window
>Hit /cgi-bin/koha/mainpage.pl?logout.x=1
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>---
> C4/Auth.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index a44cd09767..9d44366e49 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -982,7 +982,7 @@ sub checkauth {
> 
>         # voluntary logout the user
>         # check wether the user was using their shibboleth session or a local one
>-        my $shibSuccess = C4::Context->userenv->{'shibboleth'};
>+        my $shibSuccess = C4::Context->userenv ? C4::Context->userenv->{'shibboleth'} : undef;
>         if ( $session ) {
>             $session->delete();
>             $session->flush;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31244: 138147 | 138148 | 138188 | 145696 | 145717