Bugzilla – Attachment 13820 Details for
Bug 8781
Access to Transfer page while "independent branches" is on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8781: hiding of transfer page when it's useless
SIGNED-OFF-Bug-8781-hiding-of-transfer-page-when-i.patch (text/plain), 2.87 KB, created by
Katrin Fischer
on 2012-12-02 13:16:42 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8781: hiding of transfer page when it's useless
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2012-12-02 13:16:42 UTC
Size:
2.87 KB
patch
obsolete
>From ae48067fedfad532801a910881ee5cdcf9efbada Mon Sep 17 00:00:00 2001 >From: Adrien Saurat <adrien.saurat@biblibre.com> >Date: Tue, 18 Sep 2012 10:27:39 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 8781: hiding of transfer page when it's > useless > >The transfer page is only useful when the system >preference "IndependantBranches" is Off of when the user >is a superlibrarian. Otherwise it can be hidden. > >Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >All tests and perlcritic pass. > >TEST PLAN : >It's about testing the display of the "Transfer" link on "circulation-home.pl". >The link needs to appear if IndependantBranches is off or if the user is a superlibrarian. > >1) IndependantBranches = Off, user is superlibrarian : link appears >2) IndependantBranches = Off, user is not superlibrarian : link appears >3) IndependantBranches = On, user is superlibrarian : link appears >4) IndependantBranches = On, user is not superlibrarian : link does not appear >--- > circ/circulation-home.pl | 5 ++++- > .../prog/en/modules/circ/circulation-home.tt | 2 ++ > 2 files changed, 6 insertions(+), 1 deletion(-) > >diff --git a/circ/circulation-home.pl b/circ/circulation-home.pl >index 842f8d9..5eee81b 100755 >--- a/circ/circulation-home.pl >+++ b/circ/circulation-home.pl >@@ -25,7 +25,7 @@ use C4::Context; > use C4::Koha; > > my $query = new CGI; >-my ($template, $loggedinuser, $cookie) >+my ($template, $loggedinuser, $cookie, $flags) > = get_template_and_user({template_name => "circ/circulation-home.tmpl", > query => $query, > type => "intranet", >@@ -37,5 +37,8 @@ my ($template, $loggedinuser, $cookie) > my $fa = getframeworkinfo('FA'); > $template->param( fast_cataloging => 1 ) if (defined $fa); > >+# Checking if the transfer page needs to be displayed >+$template->param( display_transfer => 1 ) if ( ($flags->{'superlibrarian'} == 1) || (C4::Context->preference("IndependantBranches") == 0) ); >+ > > output_html_with_http_headers $query, $cookie, $template->output; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >index 8b4ad57..aa1b700 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >@@ -19,7 +19,9 @@ > <ul> > <li><a href="/cgi-bin/koha/circ/circulation.pl">Check out</a></li> > <li><a href="/cgi-bin/koha/circ/returns.pl">Check in</a></li> >+ [% IF ( display_transfer ) %] > <li><a href="/cgi-bin/koha/circ/branchtransfers.pl">Transfer</a></li> >+ [% END %] > [% IF ( AutoLocation ) %][% ELSE %][% IF ( IndependantBranches ) %][% ELSE %]<li><a href="/cgi-bin/koha/circ/selectbranchprinter.pl">Set library</a></li>[% END %][% END %] > [% IF ( fast_cataloging ) %] > [% IF ( CAN_user_editcatalogue_fast_cataloging ) %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8781
:
12298
|
13321
| 13820