Attachment 138242 Details for Bug 24616 – Bug 24616: Allow copying notice to a branch even if it exists in that branch

[patch] Bug 24616: Allow copying notice to a branch even if it exists in that branch

0001-Bug-24616-Allow-copying-notice-to-a-branch-even-if-i.patch (text/plain), 1.59 KB, created by Emmi Takkinen on 2022-07-29 06:05:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmi Takkinen

Created: 2022-07-29 06:05:10 UTC

Size: 1.59 KB

patch

obsolete

>From 5e23812aecc751e9626cb99c05cbf7562bea61cc Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Thu, 28 Jul 2022 15:22:20 +0300
>Subject: [PATCH] Bug 24616: Allow copying notice to a branch even if it exists
> in that branch
>
>If you try to copy notice or slip to a branch which already
>has that notice or slip Koha won't let you save it. Instead
>pop-up saying branch already has that notice is displayed.
>
>This patch allows users to copy and override already existing
>notice or slip.
>
>To test:
>1. Find notice which exists e.g. in all branches and branch A.
>2. Copy that notice, add notice screen is displayed.
>3. Press save.
>=> Pop-up informing that notice already exists in branch A
>is displayed.
>4. Apply this patch.
>5. Repeat steps 2. and 3.
>=> Notice is saved succesfully.
>
>Also try to save the notice you tested with as a new (same code)
>to branch A. Confirm that pop-up is displayed as it should be.
>
>Sponsored-by: Koha-Suomi Oy
>---
> koha-tmpl/intranet-tmpl/prog/js/letter.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/letter.js b/koha-tmpl/intranet-tmpl/prog/js/letter.js
>index 53ac7b120e..e40d3c485a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/letter.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/letter.js
>@@ -4,7 +4,7 @@
> var modal_loading = "<div id=\"loading\"><img src=\"" + interface + "/" + theme + "/img/spinner-small.gif\" alt=\"\" /> "+ __('Loading...') +"</div>";
> 
> var editing = 0;
>-if( add_form == 1 && code !== '' ){
>+if( add_form == 1 && code !== '' || copy_form == 1 && code !== ''){
>     editing = 1;
> }
> 
>-- 
>2.25.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 24616: 138242 | 138503 | 142672 | 142850 | 142856 | 145238 | 146148 | 146149 | 146150