Attachment 138301 Details for Bug 30308 – Bug 30308: Fix bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData)

[patch] Bug 30308: Fix bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData)

Bug-30308-Fix-bulkmarcimportpl-broken-by-OAI-PMHAu.patch (text/plain), 1.65 KB, created by Kyle M Hall (khall) on 2022-07-29 11:41:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-07-29 11:41:56 UTC

Size: 1.65 KB

patch

obsolete

>From cab53b996439e10efc5898063bc6858a9f687f54 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Mon, 11 Jul 2022 12:05:54 +0200
>Subject: [PATCH] Bug 30308: Fix bulkmarcimport.pl broken by
> OAI-PMH:AutoUpdateSets(EmbedItemData)
>
>Test plan:
>
>(A) Reproduce the bug:
>
>A1 In Administration > System preferences > Web services:
>   - Enable OAI-PMH
>   - Enable OAI-PMH:AutoUpdateSets
>   - Enable OAI-PMH:AutoUpdateSetsEmbedItemData
>
>A2 In Tools > Export data > Export bibliographic records, export 1 (one)
>   biblio record. Be sure that this biblio record has at least one item.
>   Don't tick "Don't export items".
>
>A3 Delete the exported biblio record, and its items.
>
>A4 In command line, on the server load the exported file:
>   ./bulkmarcimport.pl -b -v -file /path/to/koha.mrc
>
>A5 Retrieve the biblio record in Koha. Note the absence of the item(s). This is
>   the bug.
>
>(B) Apply the patch
>
>B1 Delete the record (without item) loaded at A4.
>
>B2 In command line, on the server load the exported file:
>   ./bulkmarcimport.pl -b -v -file /path/to/koha.mrc
>
>B2 Retrieve the biblio record in Koha. Note the presence of the item(s).
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/OAI/Sets.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/OAI/Sets.pm b/C4/OAI/Sets.pm
>index fc876769f4f..a81183bb321 100644
>--- a/C4/OAI/Sets.pm
>+++ b/C4/OAI/Sets.pm
>@@ -610,6 +610,7 @@ sub UpdateOAISetsBiblio {
> 
>     return unless($biblionumber and $record);
> 
>+    $record = $record->clone;
>     if (C4::Context->preference('OAI-PMH:AutoUpdateSetsEmbedItemData')) {
>         $record = Koha::Biblio::Metadata->record(
>             {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30308: 137502 | 137630 | 137721 | 138301