Bugzilla – Attachment 138314 Details for
Bug 23919
Make ISSN searchable with and without hyphen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23919: Items search by ISBN variations and ISSN variations
Bug-23919-Items-search-by-ISBN-variations-and-ISSN.patch (text/plain), 2.71 KB, created by
Kyle M Hall (khall)
on 2022-07-29 13:23:47 UTC
(
hide
)
Description:
Bug 23919: Items search by ISBN variations and ISSN variations
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-07-29 13:23:47 UTC
Size:
2.71 KB
patch
obsolete
>From 8712cc95bef9878a3ff27a6433e5ad819542864c Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Wed, 27 Apr 2022 00:22:54 +0300 >Subject: [PATCH] Bug 23919: Items search by ISBN variations and ISSN > variations > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Items.pm | 40 ++++++++++++++++++++++++++++++++-------- > 1 file changed, 32 insertions(+), 8 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 80c224b4cdd..443242be5d9 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -1299,6 +1299,22 @@ sub _SearchItems_build_where_fragment { > } > $column = "ExtractValue($sqlfield, '$xpath')"; > } >+ } >+ elsif ($field eq 'isbn') { >+ if ( C4::Context->preference("SearchWithISBNVariations") and $query ) { >+ my @isbns = C4::Koha::GetVariationsOfISBN( $query ); >+ $query = []; >+ push @$query, @isbns; >+ } >+ $column = $field; >+ } >+ elsif ($field eq 'issn') { >+ if ( C4::Context->preference("SearchWithISSNVariations") and $query ) { >+ my @issns = C4::Koha::GetVariationsOfISSN( $query ); >+ $query = []; >+ push @$query, @issns; >+ } >+ $column = $field; > } else { > $column = $field; > } >@@ -1308,15 +1324,23 @@ sub _SearchItems_build_where_fragment { > } > > if (ref $query eq 'ARRAY') { >- if ($op eq '=') { >- $op = 'IN'; >- } elsif ($op eq '!=') { >- $op = 'NOT IN'; >+ if ($op eq 'like') { >+ $where_fragment = { >+ str => "($column LIKE " . join (" OR $column LIKE ", ('?') x @$query ) . ")", >+ args => $query, >+ }; >+ } >+ else { >+ if ($op eq '=') { >+ $op = 'IN'; >+ } elsif ($op eq '!=') { >+ $op = 'NOT IN'; >+ } >+ $where_fragment = { >+ str => "$column $op (" . join (',', ('?') x @$query) . ")", >+ args => $query, >+ }; > } >- $where_fragment = { >- str => "$column $op (" . join (',', ('?') x @$query) . ")", >- args => $query, >- }; > } elsif ( $op eq 'is' ) { > $where_fragment = { > str => "$column $op $query", >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23919
:
134381
|
134382
|
134383
|
134384
|
134385
|
134422
|
134423
|
134424
|
134425
|
134426
|
134440
|
134441
|
134442
|
134443
|
134444
|
135288
|
135289
|
135290
|
135291
|
135292
|
138311
|
138312
|
138313
| 138314 |
138315
|
138480