Bugzilla – Attachment 138375 Details for
Bug 30650
Add a curbside pickup module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30650: (QA follow-up) Some higher-level methods usage
Bug-30650-QA-follow-up-Some-higher-level-methods-u.patch (text/plain), 1.53 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-07-29 18:39:36 UTC
(
hide
)
Description:
Bug 30650: (QA follow-up) Some higher-level methods usage
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-07-29 18:39:36 UTC
Size:
1.53 KB
patch
obsolete
>From 5a4194ead493623f9b3144f6f156890cdd25e594 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 29 Jul 2022 15:38:51 -0300 >Subject: [PATCH] Bug 30650: (QA follow-up) Some higher-level methods usage > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/CurbsidePickup.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/Koha/CurbsidePickup.pm b/Koha/CurbsidePickup.pm >index f9fce8baa9..cbbd1632d3 100644 >--- a/Koha/CurbsidePickup.pm >+++ b/Koha/CurbsidePickup.pm >@@ -62,8 +62,7 @@ sub new { > > if ( $policy->enable_waiting_holds_only ) { > my $patron = Koha::Patrons->find( $params->{borrowernumber} ); >- my $waiting_holds = $patron->holds->search( >- { found => 'W', branchcode => $params->{branchcode} } ); >+ my $waiting_holds = $patron->holds->waiting->search( { branchcode => $params->{branchcode} } ); > > Koha::Exceptions::CurbsidePickup::NoWaitingHolds->throw > unless $waiting_holds->count; >@@ -245,7 +244,7 @@ sub mark_as_delivered { > my $holds = $patron->holds; > my $branchcode = C4::Context->userenv ? C4::Context->userenv->{branch} : undef; > foreach my $hold ( $holds->as_list ) { >- if ( $hold->found eq 'W' && $branchcode && $hold->branchcode eq $branchcode ) { >+ if ( $hold->is_waiting && $branchcode && $hold->branchcode eq $branchcode ) { > my ( $issuingimpossible, $needsconfirmation ) = > C4::Circulation::CanBookBeIssued( $patron, $hold->item->barcode ); > >-- >2.37.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30650
:
136584
|
136585
|
136586
|
136587
|
136588
|
136589
|
136590
|
136591
|
136592
|
136593
|
136594
|
136595
|
136596
|
136597
|
136598
|
136599
|
136600
|
136601
|
136602
|
136603
|
136604
|
136605
|
136606
|
136607
|
136608
|
136609
|
136610
|
137095
|
137100
|
137199
|
137211
|
137212
|
137277
|
137278
|
137279
|
137280
|
137281
|
137282
|
137283
|
137284
|
137285
|
137286
|
137287
|
137288
|
137289
|
137290
|
137291
|
137292
|
137293
|
137294
|
137295
|
137296
|
137297
|
137298
|
137299
|
137300
|
137301
|
137302
|
137303
|
137304
|
137305
|
137306
|
137307
|
138261
|
138262
|
138263
|
138264
|
138265
|
138266
|
138267
|
138268
|
138269
|
138270
|
138271
|
138272
|
138273
|
138274
|
138275
|
138276
|
138277
|
138278
|
138279
|
138280
|
138281
|
138282
|
138283
|
138284
|
138285
|
138286
|
138287
|
138288
|
138289
|
138290
|
138291
|
138292
|
138319
|
138320
|
138321
|
138322
|
138323
|
138324
|
138325
|
138330
|
138331
|
138332
|
138333
|
138334
|
138335
|
138336
|
138337
|
138338
|
138339
|
138340
|
138341
|
138342
|
138343
|
138344
|
138345
|
138346
|
138347
|
138348
|
138349
|
138350
|
138351
|
138352
|
138353
|
138354
|
138355
|
138356
|
138357
|
138358
|
138359
|
138360
|
138361
|
138362
|
138363
|
138364
|
138365
|
138366
|
138367
|
138368
|
138369
| 138375 |
138401
|
138610