Attachment 138389 Details for Bug 30499 – Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts

[patch] Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts

Bug-30499-Move-the-include-for-catalogue-search-bo.patch (text/plain), 2.71 KB, created by Joonas Kylmälä on 2022-07-30 16:33:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2022-07-30 16:33:29 UTC

Size: 2.71 KB

patch

obsolete

>From 3a025a7a034856133425644c591d2dee0eb97101 Mon Sep 17 00:00:00 2001
>From: Tim McMahon <tmcmahon@wlpl.org>
>Date: Fri, 29 Jul 2022 13:29:52 -0500
>Subject: [PATCH] Bug 30499: Move the include for catalogue-search-box.inc in
> circ-search.inc to correct keyboard shortcuts
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Keyboard shortcuts for catalog search, check in and renew should be following:
>1) Alt-q for catalog search
>2) Alt-r for check in
>3) Alt-w for renew
>
>However on some of the pages shortcuts get mixed up:
>
>1) Alt-w for catalog search
>2) Alt-q for check in
>3) Alt-r for renew
>
>Affected files are:
>circ/pendingreserves.tt
>circ/circulation_batch_checkouts.tt
>circ/circulation-home.tt
>circ/branchtransfers.tt
>circ/branchoverdues.tt
>circ/set-library.tt
>circ/checkout-notes.tt
>circ/renew.tt
>circ/waitingreserves.tt
>circ/transferstoreceive.tt
>circ/offline.tt
>circ/bookcount.tt
>circ/on-site_checkouts.tt
>circ/circulation.tt
>circ/transfers_to_send.tt
>circ/request-article.tt
>circ/overdue.tt
>circ/reserveratios.tt
>offline_circ/list.tt
>offline_circ/process_koc.tt
>offline_circ/enqueue_koc.tt
>plugins/plugins-upload.tt
>plugins/plugins-disabled.tt
>pos/registers.tt
>pos/register.tt
>pos/pay.tt
>reports/reports-home.tt
>reports/dictionary.tt
>reports/guided_reports_start.tt
>reserve/request.tt
>tools/scheduler.tt
>
>This is because the include statement for catalogue-search-box.inc is in the wrong line in circ-search.inc.
>
>To test:
>1) Go to an affected page (circulation-home was the first one I noticed)
>2) Try the keyboard shortcuts and notice they are incorrect
>3) Apply patch and refresh the page
>4) Notice that the keys work properly
>
>Signed-off-by: Andrew <andrewfh@dubcolib.org>
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc
>index 5e84e25a79..81d74af06a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc
>@@ -4,7 +4,6 @@
> 
> <div id="header_search">
>     [% INCLUDE 'patron-search-box.inc' %]
>-    [% INCLUDE 'catalogue-search-box.inc' %]
> [% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
> <div id="checkin_search" class="residentsearch">
>     <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off">
>@@ -21,6 +20,7 @@
>     </form>
> </div>
> [% END %]
>+    [% INCLUDE 'catalogue-search-box.inc' %]
> 
> <ul>
>     [% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]<li><a class="keep_text" href="#circ_search">Check out</a></li>[% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30499: 138208 | 138373 | 138374 | 138376 | 138389