Attachment 138483 Details for Bug 30392 – Bug 30392: (QA follow-up) Correct COMMENT

[patch] Bug 30392: (QA follow-up) Correct COMMENT

Bug-30392-QA-follow-up-Correct-COMMENT.patch (text/plain), 3.82 KB, created by Tomás Cohen Arazi (tcohen) on 2022-08-01 17:32:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-08-01 17:32:35 UTC

Size: 3.82 KB

patch

obsolete

>From aafc4cab02f43f7238a18495958071e159e2bab9 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 1 Aug 2022 14:30:17 -0300
>Subject: [PATCH] Bug 30392: (QA follow-up) Correct COMMENT
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/atomicupdate/bug_30392.pl | 4 ++--
> installer/data/mysql/kohastructure.sql         | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_30392.pl b/installer/data/mysql/atomicupdate/bug_30392.pl
>index b5e2a32d575..2910fe431e1 100755
>--- a/installer/data/mysql/atomicupdate/bug_30392.pl
>+++ b/installer/data/mysql/atomicupdate/bug_30392.pl
>@@ -9,14 +9,14 @@ return {
>         unless ( column_exists('items', 'deleted_on') ) {
>             $dbh->do(q{
>                 ALTER TABLE items
>-                ADD COLUMN deleted_on DATETIME DEFAULT NULL COMMENT 'date of the deletion'
>+                ADD COLUMN deleted_on DATETIME DEFAULT NULL COMMENT 'date/time of deletion'
>                 AFTER timestamp
>             });
>         }
>         unless ( column_exists('deleteditems', 'deleted_on') ) {
>             $dbh->do(q{
>                 ALTER TABLE deleteditems
>-                ADD COLUMN deleted_on DATETIME DEFAULT NULL COMMENT 'date of the deletion'
>+                ADD COLUMN deleted_on DATETIME DEFAULT NULL COMMENT 'date/time of deletion'
>                 AFTER timestamp
>             });
>         }
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 95bc6d890dc..3f524aec6a9 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -2650,7 +2650,7 @@ CREATE TABLE `deleteditems` (
>   `itemnotes_nonpublic` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'non-public notes on this item (MARC21 952$x)',
>   `holdingbranch` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'foreign key from the branches table for the library that is currently in possession item (MARC21 952$b)',
>   `timestamp` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date and time this item was last altered',
>-  `deleted_on` DATETIME DEFAULT NULL COMMENT 'date of the deletion',
>+  `deleted_on` DATETIME DEFAULT NULL COMMENT 'date/time of deletion',
>   `location` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'authorized value for the shelving location for this item (MARC21 952$c)',
>   `permanent_location` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'linked to the CART and PROC temporary locations feature, stores the permanent shelving location',
>   `onloan` date DEFAULT NULL COMMENT 'defines if item is checked out (NULL for not checked out, and due date for checked out)',
>@@ -3212,7 +3212,7 @@ CREATE TABLE `items` (
>   `itemnotes_nonpublic` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'non-public notes on this item (MARC21 952$x)',
>   `holdingbranch` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'foreign key from the branches table for the library that is currently in possession item (MARC21 952$b)',
>   `timestamp` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date and time this item was last altered',
>-  `deleted_on` DATETIME DEFAULT NULL COMMENT 'date of the deletion',
>+  `deleted_on` DATETIME DEFAULT NULL COMMENT 'date/time of deletion',
>   `location` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'authorized value for the shelving location for this item (MARC21 952$c)',
>   `permanent_location` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'linked to the CART and PROC temporary locations feature, stores the permanent shelving location',
>   `onloan` date DEFAULT NULL COMMENT 'defines if item is checked out (NULL for not checked out, and due date for checked out)',
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 30392: 138073 | 138115 | 138232 | 138233 | 138481 | 138482 | 138483 | 138500