Attachment 138572 Details for Bug 27272 – Bug 27272: Add tests for search_ordered

[patch] Bug 27272: Add tests for search_ordered

Bug-27272-Add-tests-for-searchordered.patch (text/plain), 6.68 KB, created by Victor Grousset/tuxayo on 2022-08-03 23:45:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2022-08-03 23:45:27 UTC

Size: 6.68 KB

patch

obsolete

>From de81cc40b3abf63edd459c1b26faea796933097d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 29 Jul 2022 13:06:20 +0200
>Subject: [PATCH] Bug 27272: Add tests for search_ordered
>
>---
> t/db_dependent/Koha/Items.t | 122 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 121 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Items.t b/t/db_dependent/Koha/Items.t
>index a9f0716433..77d4b7d2ff 100755
>--- a/t/db_dependent/Koha/Items.t
>+++ b/t/db_dependent/Koha/Items.t
>@@ -19,7 +19,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 15;
>+use Test::More tests => 16;
> 
> use Test::MockModule;
> use Test::Exception;
>@@ -27,6 +27,7 @@ use Time::Fake;
> 
> use C4::Circulation qw( AddIssue LostItem AddReturn );
> use C4::Context;
>+use C4::Serials qw( NewIssue AddItem2Serial );
> use Koha::Item;
> use Koha::Item::Transfer::Limits;
> use Koha::Items;
>@@ -1811,3 +1812,122 @@ subtest 'move_to_biblio() tests' => sub {
>     $schema->storage->txn_rollback;
> 
> };
>+
>+subtest 'search_ordered' => sub {
>+
>+    plan tests => 6;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $library_a = $builder->build_object(
>+        { class => 'Koha::Libraries', value => { branchname => 'TEST_A' } } );
>+    my $library_z = $builder->build_object(
>+        { class => 'Koha::Libraries', value => { branchname => 'TEST_Z' } } );
>+    my $biblio = $builder->build_sample_biblio( { serial => 0 } );
>+    my $item1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
>+    my $item2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
>+    my $item3 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
>+
>+    { # Is not a serial
>+
>+        # order_by homebranch.branchname
>+        $item1->discard_changes->update( { homebranch => $library_z->branchcode } );
>+        $item2->discard_changes->update( { homebranch => $library_a->branchcode } );
>+        $item3->discard_changes->update( { homebranch => $library_z->branchcode } );
>+        is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ],
>+            [ $item2->itemnumber, $item1->itemnumber, $item3->itemnumber ] );
>+
>+        # order_by me.enumchron
>+        $biblio->items->update( { homebranch => $library_a->branchcode } );
>+        $item1->discard_changes->update( { enumchron => 'cc' } );
>+        $item2->discard_changes->update( { enumchron => 'bb' } );
>+        $item3->discard_changes->update( { enumchron => 'aa' } );
>+        is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ],
>+            [ $item3->itemnumber, $item2->itemnumber, $item1->itemnumber ] );
>+
>+        # order_by LPAD( me.copynumber, 8, '0' )
>+        $biblio->items->update( { enumchron => undef } );
>+        $item1->discard_changes->update( { copynumber => '12345678' } );
>+        $item2->discard_changes->update( { copynumber => '34567890' } );
>+        $item3->discard_changes->update( { copynumber => '23456789' } );
>+        is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ],
>+            [ $item1->itemnumber, $item3->itemnumber, $item2->itemnumber ] );
>+
>+        # order_by -desc => 'me.dateaccessioned'
>+        $biblio->items->update( { copynumber => undef } );
>+        $item1->discard_changes->update( { dateaccessioned => '2022-08-19' } );
>+        $item2->discard_changes->update( { dateaccessioned => '2022-07-19' } );
>+        $item3->discard_changes->update( { dateaccessioned => '2022-09-19' } );
>+        is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ],
>+            [ $item3->itemnumber, $item1->itemnumber, $item2->itemnumber ] );
>+    }
>+
>+    {    # Is a serial
>+
>+        my $sub_freq = $builder->build( { source => 'SubscriptionFrequency' } );
>+        my $sub_np =
>+          $builder->build( { source => 'SubscriptionNumberpattern' } );
>+        my $subscription = $builder->build_object(
>+            {
>+                class => 'Koha::Subscriptions',
>+                value => {
>+                    biblionumber  => $biblio->biblionumber,
>+                    periodicity   => $sub_freq->{id},
>+                    numberpattern => $sub_np->{id}
>+                }
>+            }
>+        );
>+        $builder->build_object(
>+            {
>+                class => 'Koha::Subscription::Histories',
>+                value => {
>+                    subscriptionid => $subscription->subscriptionid,
>+                    biblionumber   => $biblio->biblionumber
>+                }
>+            }
>+        );
>+
>+        $biblio->update( { serial => 1 } );
>+        my $serialid1 =
>+          C4::Serials::NewIssue( "serialseq", $subscription->subscriptionid,
>+            $biblio->biblionumber, 1, undef, undef, "publisheddatetext",
>+            "notes", "routingnotes" );
>+        C4::Serials::AddItem2Serial( $serialid1, $item1->itemnumber );
>+        my $serialid2 =
>+          C4::Serials::NewIssue( "serialseq", $subscription->subscriptionid,
>+            $biblio->biblionumber, 1, undef, undef, "publisheddatetext",
>+            "notes", "routingnotes" );
>+        C4::Serials::AddItem2Serial( $serialid2, $item2->itemnumber );
>+        my $serialid3 =
>+          C4::Serials::NewIssue( "serialseq", $subscription->subscriptionid,
>+            $biblio->biblionumber, 1, undef, undef, "publisheddatetext",
>+            "notes", "routingnotes" );
>+        C4::Serials::AddItem2Serial( $serialid3, $item3->itemnumber );
>+        my $serial1 = Koha::Serials->find($serialid1);
>+        my $serial2 = Koha::Serials->find($serialid2);
>+        my $serial3 = Koha::Serials->find($serialid3);
>+
>+        # order_by serial.publisheddate
>+        $serial1->discard_changes->update( { publisheddate => '2022-09-19' } );
>+        $serial2->discard_changes->update( { publisheddate => '2022-07-19' } );
>+        $serial3->discard_changes->update( { publisheddate => '2022-08-19' } );
>+        is_deeply(
>+            [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ],
>+            [ $item2->itemnumber, $item3->itemnumber, $item1->itemnumber ]
>+        );
>+
>+        # order_by me.enumchron
>+        $serial1->discard_changes->update({ publisheddate => '2022-08-19' });
>+        $serial2->discard_changes->update({ publisheddate => '2022-08-19' });
>+        $serial3->discard_changes->update({ publisheddate => '2022-08-19' });
>+        $item1->discard_changes->update( { enumchron => 'cc' } );
>+        $item2->discard_changes->update( { enumchron => 'bb' } );
>+        $item3->discard_changes->update( { enumchron => 'aa' } );
>+        is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ],
>+            [ $item3->itemnumber, $item2->itemnumber, $item1->itemnumber ] );
>+
>+    }
>+
>+    $schema->storage->txn_rollback;
>+
>+};
>-- 
>2.37.1

Actions: View | Diff | Splinter Review

Attachments on bug 27272: 128230 | 128231 | 135640 | 135641 | 135642 | 135643 | 135644 | 135645 | 135646 | 135647 | 135648 | 135649 | 135650 | 135651 | 135652 | 135653 | 135654 | 135655 | 135656 | 135657 | 135658 | 135659 | 137966 | 137967 | 137968 | 137969 | 137970 | 137971 | 137972 | 137973 | 137974 | 137975 | 137976 | 137977 | 137978 | 137979 | 137980 | 137981 | 137982 | 138109 | 138296 | 138297 | 138298 | 138303 | 138304 | 138305 | 138306 | 138307 | 138308 | 138437 | 138438 | 138439 | 138440 | 138441 | 138442 | 138553 | 138554 | 138555 | 138556 | 138557 | 138558 | 138559 | 138560 | 138561 | 138562 | 138563 | 138564 | 138565 | 138566 | 138567 | 138568 | 138569 | 138570 | 138571 | 138572 | 138573 | 138574 | 138575 | 138614 | 138615 | 138616 | 138617 | 138618 | 138619 | 138620 | 138621 | 138622 | 138623 | 138624 | 138625 | 138626 | 138627 | 138628 | 138629 | 138630 | 138631 | 138632 | 138633 | 138634 | 138635 | 138636 | 138714 | 138715 | 138716 | 138717 | 138718 | 138719 | 138720 | 138721 | 138722 | 138723 | 138724 | 138725 | 138726 | 138727 | 138728 | 138729 | 138730 | 138731 | 138732 | 138733 | 138734 | 138735 | 138736 | 138773 | 138774 | 138775 | 138776 | 138777 | 138778 | 138779 | 138780 | 138781 | 138782 | 138783 | 138784 | 138785 | 138786 | 138787 | 138788 | 138789 | 138790 | 138791 | 138792 | 138793 | 138794 | 138832 | 139928