Attachment 138676 Details for Bug 29897 – Bug 29897: Remove 'linkage' leftover

[patch] Bug 29897: Remove 'linkage' leftover

Bug-29897-Remove-linkage-leftover.patch (text/plain), 1.63 KB, created by Katrin Fischer on 2022-08-05 10:56:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-08-05 10:56:10 UTC

Size: 1.63 KB

patch

obsolete

>From be6039b6e368a5c3ba9208e45ff6c04a0998876c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 29 Jul 2022 18:28:03 +0200
>Subject: [PATCH] Bug 29897: Remove 'linkage' leftover
>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>---
> Koha/Authority.pm                 | 3 +--
> t/db_dependent/Koha/Authorities.t | 2 --
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/Koha/Authority.pm b/Koha/Authority.pm
>index 0a6d30c616..ff45d20a3d 100644
>--- a/Koha/Authority.pm
>+++ b/Koha/Authority.pm
>@@ -136,9 +136,8 @@ sub get_identifiers {
>     for my $field ( $record->field('024') ) {
>         my $sf_2 = $field->subfield('2');
>         my $sf_a = $field->subfield('a');
>-        my $sf_6 = $field->subfield('6');
>         next unless $sf_2 && $sf_a;
>-        push @identifiers, {source => $sf_2, number => $sf_a, linkage => $sf_6};
>+        push @identifiers, {source => $sf_2, number => $sf_a, };
>     }
> 
>     return \@identifiers;
>diff --git a/t/db_dependent/Koha/Authorities.t b/t/db_dependent/Koha/Authorities.t
>index a9c507df83..5dbfaaa497 100755
>--- a/t/db_dependent/Koha/Authorities.t
>+++ b/t/db_dependent/Koha/Authorities.t
>@@ -276,12 +276,10 @@ subtest 'get_identifiers' => sub {
>             {
>                 source  => 'orcid',
>                 number  => '0000-0002-1234-5678',
>-                linkage => 'https://orcid.org/0000-0002-1234-5678'
>             },
>             {
>                 source => 'scopus',
>                 number => '01234567890',
>-                linkage => 'https://www.scopus.com/authid/detail.uri?authorId=01234567890'
>             }
>         ]
>     );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29897: 129816 | 129817 | 129818 | 129819 | 132961 | 132962 | 132963 | 132964 | 133081 | 133113 | 133114 | 133115 | 133116 | 133117 | 134459 | 134460 | 134461 | 134462 | 134463 | 134464 | 135983 | 135984 | 135985 | 135986 | 135987 | 135988 | 135989 | 135990 | 135991 | 135992 | 135993 | 138249 | 138250 | 138251 | 138252 | 138253 | 138254 | 138255 | 138256 | 138257 | 138258 | 138259 | 138260 | 138371 | 138372 | 138425 | 138426 | 138427 | 138428 | 138429 | 138430 | 138431 | 138432 | 138433 | 138434 | 138435 | 138486 | 138487 | 138490 | 138501 | 138664 | 138665 | 138666 | 138667 | 138668 | 138669 | 138670 | 138671 | 138672 | 138673 | 138674 | 138675 | 138676 | 138677 | 138678 | 138679