Bugzilla – Attachment 138679 Details for
Bug 29897
Display author identifiers for researchers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29897: Don't display empty li
Bug-29897-Dont-display-empty-li.patch (text/plain), 4.53 KB, created by
Katrin Fischer
on 2022-08-05 10:56:23 UTC
(
hide
)
Description:
Bug 29897: Don't display empty li
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-08-05 10:56:23 UTC
Size:
4.53 KB
patch
obsolete
>From a54cb1935cc9f6fae3983899fc05d9b2daacbe72 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 2 Aug 2022 06:54:59 +0200 >Subject: [PATCH] Bug 29897: Don't display empty li > >It's ugly to move the li to the include file, but it's the easiest for >now... > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > .../en/includes/authority-identifiers.inc | 30 ++++++++++++------- > .../bootstrap/en/modules/opac-auth-detail.tt | 4 +-- > .../bootstrap/en/modules/opac-detail.tt | 4 +-- > 3 files changed, 22 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-identifiers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-identifiers.inc >index 55077ddbb2..85d68c09be 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-identifiers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-identifiers.inc >@@ -1,17 +1,27 @@ > [% SWITCH identifier.source.lower %] > [% CASE 'orcid' %] >- <span>ORCID: </span> >- <a href="https://orcid.org/[% identifier.number | url %]">[% identifier.number | html %]</a> >+ <li> >+ <span>ORCID: </span> >+ <a href="https://orcid.org/[% identifier.number | url %]">[% identifier.number | html %]</a> >+ </li> > [% CASE 'scopus' %] >- <span>ScopusID: </span> >- <a href="https://www.scopus.com/authid/detail.uri?authorId=[% identifier.number | url %]">[% identifier.number | html %]</a> >+ <li> >+ <span>ScopusID: </span> >+ <a href="https://www.scopus.com/authid/detail.uri?authorId=[% identifier.number | url %]">[% identifier.number | html %]</a> >+ </li> > [% CASE 'loop' %] >- <span>loop: </span> >- <a href="https://loop.frontiersin.org/people/[% identifier.number | url %]">[% identifier.number | html %]</a> >+ <li> >+ <span>loop: </span> >+ <a href="https://loop.frontiersin.org/people/[% identifier.number | url %]">[% identifier.number | html %]</a> >+ </li> > [% CASE 'rid' %] >- <span>Publons: </span> >- <a href="https://publons.com/researcher/[% identifier.number | url %]">[% identifier.number | html %]</a> >+ <li> >+ <span>Publons: </span> >+ <a href="https://publons.com/researcher/[% identifier.number | url %]">[% identifier.number | html %]</a> >+ </li> > [% CASE 'viaf' %] >- <span>VIAF: </span> >- <a href="https://viaf.org/viaf/[% identifier.number | url %]">[% identifier.number | html %]</a> >+ <li> >+ <span>VIAF: </span> >+ <a href="https://viaf.org/viaf/[% identifier.number | url %]">[% identifier.number | html %]</a> >+ </li> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >index 36a53eeda2..a84b103784 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >@@ -186,9 +186,7 @@ > <span>Identifiers</span> > <ul> > [% FOR identifier IN author_identifiers %] >- <li> >- [% PROCESS "authority-identifiers.inc" identifier => identifier %] >- </li> >+ [% PROCESS "authority-identifiers.inc" identifier => identifier %] > [% END %] > </ul> > </div> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 9e41a2be1a..b3607465d8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -965,9 +965,7 @@ > <span class="author_name"><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% author.authid | uri %]">[% author.name | html %]</a></span> > <ul> > [% FOR identifier IN author.identifiers %] >- <li> >- [% PROCESS "authority-identifiers.inc" identifier => identifier %] >- </li> >+ [% PROCESS "authority-identifiers.inc" identifier => identifier %] > [% END %] > </ul> > </div> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29897
:
129816
|
129817
|
129818
|
129819
|
132961
|
132962
|
132963
|
132964
|
133081
|
133113
|
133114
|
133115
|
133116
|
133117
|
134459
|
134460
|
134461
|
134462
|
134463
|
134464
|
135983
|
135984
|
135985
|
135986
|
135987
|
135988
|
135989
|
135990
|
135991
|
135992
|
135993
|
138249
|
138250
|
138251
|
138252
|
138253
|
138254
|
138255
|
138256
|
138257
|
138258
|
138259
|
138260
|
138371
|
138372
|
138425
|
138426
|
138427
|
138428
|
138429
|
138430
|
138431
|
138432
|
138433
|
138434
|
138435
|
138486
|
138487
|
138490
|
138501
|
138664
|
138665
|
138666
|
138667
|
138668
|
138669
|
138670
|
138671
|
138672
|
138673
|
138674
|
138675
|
138676
|
138677
|
138678
| 138679