Bugzilla – Attachment 138690 Details for
Bug 30500
Add option to allow user to change the pickup location while a hold is in transit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30500: (QA follow-up) Separate code execution streams for obviously independent parameters
Bug-30500-QA-follow-up-Separate-code-execution-str.patch (text/plain), 1.60 KB, created by
Peter Vashchuk
on 2022-08-05 12:48:23 UTC
(
hide
)
Description:
Bug 30500: (QA follow-up) Separate code execution streams for obviously independent parameters
Filename:
MIME Type:
Creator:
Peter Vashchuk
Created:
2022-08-05 12:48:23 UTC
Size:
1.60 KB
patch
obsolete
>From a236b020e2f95dd25f06c6996ae75399a18183fb Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Fri, 5 Aug 2022 15:47:41 +0300 >Subject: [PATCH] Bug 30500: (QA follow-up) Separate code execution streams for > obviously independent parameters > >When $new_pickup_location gets passed as parameter it doesn't make any >sense to also check is_cancelable_from_opac. > >Also this makes code more clearer as it seemed like it was possible for >item to get cancelled at the same time as request to change pickup >location. >--- > opac/opac-modrequest.pl | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > >diff --git a/opac/opac-modrequest.pl b/opac/opac-modrequest.pl >index c12ac95d244..4eb805b3597 100755 >--- a/opac/opac-modrequest.pl >+++ b/opac/opac-modrequest.pl >@@ -54,16 +54,11 @@ if ( $reserve_id && $borrowernumber ) { > exit; > } > >- if ($cancellation_request) { >+ if ( $cancellation_request ) { > $hold->add_cancellation_request > if $hold->cancellation_requestable_from_opac; > } >- else { >- $hold->cancel >- if $hold->is_cancelable_from_opac; >- } >- >- if ( $new_pickup_location ) { >+ elsif ( $new_pickup_location ) { > > if ( C4::Context->preference('OPACInTransitHoldPickupLocationChange') ) { > $hold->set_pickup_location({ library_id => $new_pickup_location }); >@@ -74,6 +69,9 @@ if ( $reserve_id && $borrowernumber ) { > exit; > } > } >+ elsif ( $hold->is_cancelable_from_opac ) { >+ $hold->cancel; >+ } > } > > print $query->redirect("/cgi-bin/koha/opac-user.pl#opac-user-holds"); >-- >2.35.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30500
:
135834
|
135835
|
135836
|
135837
|
135847
|
135848
| 138690