Attachment 138697 Details for Bug 28787 – Bug 28787: (follow-up) Changes in API auth, moved otp out of Letters

[patch] Bug 28787: (follow-up) Changes in API auth, moved otp out of Letters

Bug-28787-follow-up-Changes-in-API-auth-moved-otp-.patch (text/plain), 3.49 KB, created by Kyle M Hall (khall) on 2022-08-05 14:24:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-08-05 14:24:38 UTC

Size: 3.49 KB

patch

obsolete

>From afc988b0c9d6be5d078ed90fe6c8b6b647d5c2af Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 27 Jun 2022 11:06:34 +0000
>Subject: [PATCH] Bug 28787: (follow-up) Changes in API auth, moved otp out of
> Letters
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Sponsored-by: Rijksmuseum, Netherlands
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Letters.pm                  | 5 -----
> Koha/REST/V1/Auth.pm           | 7 ++++---
> Koha/REST/V1/TwoFactorAuth.pm  | 2 ++
> api/v1/swagger/paths/auth.yaml | 3 +++
> 4 files changed, 9 insertions(+), 8 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 134658ff968..53cde012371 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -1610,11 +1610,6 @@ sub _process_tt {
>     $content = add_tt_filters( $content );
>     $content = qq|[% USE KohaDates %][% USE Remove_MARC_punctuation %]$content|;
> 
>-    if ( $content =~ m|\[% otp_token %\]| ) {
>-        my $patron = Koha::Patrons->find(C4::Context->userenv->{number});
>-        $tt_params->{otp_token} = Koha::Auth::TwoFactorAuth->new({patron => $patron})->code;
>-    }
>-
>     my $output;
>     my $schema = Koha::Database->new->schema;
>     $schema->txn_begin;
>diff --git a/Koha/REST/V1/Auth.pm b/Koha/REST/V1/Auth.pm
>index 4fac9237c61..84e05920461 100644
>--- a/Koha/REST/V1/Auth.pm
>+++ b/Koha/REST/V1/Auth.pm
>@@ -82,7 +82,6 @@ sub under {
>         }
> 
>         if ( $c->req->url->to_abs->path eq '/api/v1/oauth/token' ) {
>-            #|| $c->req->url->to_abs->path eq '/api/v1/auth/send_otp_token' ) {
>             # Requesting a token shouldn't go through the API authenticaction chain
>             $status = 1;
>         }
>@@ -235,7 +234,10 @@ sub authenticate_api_request {
>             if ( $c->req->url->to_abs->path eq '/api/v1/auth/send_otp_token' ) {
>                 $user = Koha::Patrons->find( $session->param('number') );
>                 $cookie_auth = 1;
>-                $pending_auth = 1;
>+            } else {
>+                Koha::Exceptions::Authentication::Required->throw(
>+                    error => 'Authentication failure.'
>+                );
>             }
>         }
>         elsif ($status eq "maintenance") {
>@@ -271,7 +273,6 @@ sub authenticate_api_request {
>          ( $params->{is_public} and
>           ( C4::Context->preference('RESTPublicAnonymousRequests') or
>             $user) or $params->{is_plugin} )
>-        or $pending_auth
>     ) {
>         # We do not need any authorization
>         # Check the parameters
>diff --git a/Koha/REST/V1/TwoFactorAuth.pm b/Koha/REST/V1/TwoFactorAuth.pm
>index 35479228e58..e62136ac26e 100644
>--- a/Koha/REST/V1/TwoFactorAuth.pm
>+++ b/Koha/REST/V1/TwoFactorAuth.pm
>@@ -45,10 +45,12 @@ sub send_otp_token {
> 
>     return try {
> 
>+        my $code = Koha::Auth::TwoFactorAuth->new({patron => $patron})->code;
>         my $letter = C4::Letters::GetPreparedLetter(
>             module      => 'members',
>             letter_code => '2FA_OTP_TOKEN',
>             branchcode  => $patron->branchcode,
>+            substitute  => { otp_token => $code },
>             tables      => {
>                 borrowers => $patron->unblessed,
>             }
>diff --git a/api/v1/swagger/paths/auth.yaml b/api/v1/swagger/paths/auth.yaml
>index 3e0ac45083f..43b0decbb51 100644
>--- a/api/v1/swagger/paths/auth.yaml
>+++ b/api/v1/swagger/paths/auth.yaml
>@@ -36,3 +36,6 @@
>           * `internal_server_error`
>         schema:
>           $ref: "../swagger.yaml#/definitions/error"
>+    x-koha-authorization:
>+      permissions:
>+        catalogue: "1"
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28787: 135287 | 136571 | 136572 | 136573 | 137251 | 137330 | 137331 | 137369 | 137370 | 137371 | 137379 | 137380 | 137381 | 137391 | 137392 | 137393 | 137394 | 137395 | 137396 | 137397 | 137398 | 137399 | 137400 | 138146 | 138149 | 138150 | 138151 | 138152 | 138153 | 138154 | 138155 | 138156 | 138157 | 138158 | 138159 | 138689 | 138696 | 138697 | 138698 | 138699 | 138700 | 138701 | 138702 | 138703 | 138704 | 138705 | 138706 | 138707 | 138931 | 138932