Bugzilla – Attachment 138699 Details for
Bug 28787
Send a notice with the TOTP token
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t
Bug-28787-Fix-tdbdependentapiv1twofactorautht.patch (text/plain), 1.47 KB, created by
Kyle M Hall (khall)
on 2022-08-05 14:24:46 UTC
(
hide
)
Description:
Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-08-05 14:24:46 UTC
Size:
1.47 KB
patch
obsolete
>From ae74453cb3303cd0987014b56b7d7e4b28d118bb Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 7 Jul 2022 06:44:04 +0000 >Subject: [PATCH] Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t > >Changing flags to 20 to include the required Staff access for >intranet login. >This changes the http status. The API raises an exception now. > >Test plan: >Run t/db_dependent/api/v1/two_factor_auth.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Sponsored-by: Rijksmuseum, Netherlands > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/api/v1/two_factor_auth.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/api/v1/two_factor_auth.t b/t/db_dependent/api/v1/two_factor_auth.t >index c22fe819f8a..8a55e61e0a1 100755 >--- a/t/db_dependent/api/v1/two_factor_auth.t >+++ b/t/db_dependent/api/v1/two_factor_auth.t >@@ -46,7 +46,7 @@ subtest 'send_otp_token' => sub { > { > class => 'Koha::Patrons', > value => { >- flags => 16 >+ flags => 20, # Staff access and Patron info > } > } > ); >@@ -63,7 +63,7 @@ subtest 'send_otp_token' => sub { > $tx->req->env( { REMOTE_ADDR => $remote_address } ); > > # Patron is not authenticated yet >- $t->request_ok($tx)->status_is(403); >+ $t->request_ok($tx)->status_is(500); # FIXME Check the exception instead? > > $session->param('waiting-for-2FA', 1); > $session->flush; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28787
:
135287
|
136571
|
136572
|
136573
|
137251
|
137330
|
137331
|
137369
|
137370
|
137371
|
137379
|
137380
|
137381
|
137391
|
137392
|
137393
|
137394
|
137395
|
137396
|
137397
|
137398
|
137399
|
137400
|
138146
|
138149
|
138150
|
138151
|
138152
|
138153
|
138154
|
138155
|
138156
|
138157
|
138158
|
138159
|
138689
|
138696
|
138697
|
138698
| 138699 |
138700
|
138701
|
138702
|
138703
|
138704
|
138705
|
138706
|
138707
|
138931
|
138932