Attachment 138716 Details for Bug 27272 – Bug 27272: Remove GetItemsInfo from basket/sendbasket

[patch] Bug 27272: Remove GetItemsInfo from basket/sendbasket

Bug-27272-Remove-GetItemsInfo-from-basketsendbaske.patch (text/plain), 2.77 KB, created by Victor Grousset/tuxayo on 2022-08-05 20:13:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2022-08-05 20:13:32 UTC

Size: 2.77 KB

patch

obsolete

>From 735e654b680ab4c0688752a50d5e1290d928b438 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 2 Jun 2022 11:33:40 +0200
>Subject: [PATCH] Bug 27272: Remove GetItemsInfo from basket/sendbasket
>
>Why are we display with $raw?
>Why are we display the location code instead of the AV's lib?
>---
> basket/sendbasket.pl                                         | 5 +----
> koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt | 5 +++--
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/basket/sendbasket.pl b/basket/sendbasket.pl
>index c5bf9822fb..cbd64b3fc8 100755
>--- a/basket/sendbasket.pl
>+++ b/basket/sendbasket.pl
>@@ -25,7 +25,6 @@ use Try::Tiny qw( catch try );
> use C4::Biblio qw(
>     GetMarcSubjects
> );
>-use C4::Items qw( GetItemsInfo );
> use C4::Auth qw( get_template_and_user );
> use C4::Output qw( output_and_exit output_html_with_http_headers );
> use C4::Templates;
>@@ -76,8 +75,6 @@ if ( $email_add ) {
>         my $marcauthorsarray = $biblio->get_marc_authors;
>         my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
> 
>-        my @items = GetItemsInfo( $biblionumber );
>-
>         my $hasauthors = 0;
>         if($dat->{'author'} || @$marcauthorsarray) {
>           $hasauthors = 1;
>@@ -88,7 +85,7 @@ if ( $email_add ) {
>         $dat->{MARCAUTHORS}    = $marcauthorsarray;
>         $dat->{HASAUTHORS}     = $hasauthors;
>         $dat->{'biblionumber'} = $biblionumber;
>-        $dat->{ITEM_RESULTS}   = \@items;
>+        $dat->{ITEM_RESULTS}   = $biblio->items;
> 
>         $iso2709 .= $record->as_usmarc();
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt
>index a39f377914..c6082787cc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt
>@@ -1,6 +1,7 @@
> [% USE raw %]
> [% USE HtmlToText %]
> [% USE Koha %]
>+[% USE Branches %]
> 
> <SUBJECT>
> Your cart
>@@ -139,11 +140,11 @@ Your cart
>                 In online catalog: [% OPACBaseURL | $raw %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% BIBLIO_RESULT.biblionumber | html %]
>             </p>
>             [% END %]
>-            [% IF ( BIBLIO_RESULT.ITEM_RESULTS.size ) %]
>+            [% IF ( BIBLIO_RESULT.ITEM_RESULTS.count ) %]
>             <p>Items:
>             <ul>
>                 [% FOREACH ITEM_RESULT IN BIBLIO_RESULT.ITEM_RESULTS %]<li>
>-                    [% ITEM_RESULT.branchname | $raw %]
>+                    [% Branches.GetName(ITEM_RESULT.holdingbranch) | $raw %]
>                     [% ITEM_RESULT.location | $raw %]
>                     [% IF ITEM_RESULT.itemcallnumber %]([% ITEM_RESULT.itemcallnumber | $raw %])[% END %]
>                     [% ITEM_RESULT.barcode | $raw %]
>-- 
>2.37.1

Actions: View | Diff | Splinter Review

Attachments on bug 27272: 128230 | 128231 | 135640 | 135641 | 135642 | 135643 | 135644 | 135645 | 135646 | 135647 | 135648 | 135649 | 135650 | 135651 | 135652 | 135653 | 135654 | 135655 | 135656 | 135657 | 135658 | 135659 | 137966 | 137967 | 137968 | 137969 | 137970 | 137971 | 137972 | 137973 | 137974 | 137975 | 137976 | 137977 | 137978 | 137979 | 137980 | 137981 | 137982 | 138109 | 138296 | 138297 | 138298 | 138303 | 138304 | 138305 | 138306 | 138307 | 138308 | 138437 | 138438 | 138439 | 138440 | 138441 | 138442 | 138553 | 138554 | 138555 | 138556 | 138557 | 138558 | 138559 | 138560 | 138561 | 138562 | 138563 | 138564 | 138565 | 138566 | 138567 | 138568 | 138569 | 138570 | 138571 | 138572 | 138573 | 138574 | 138575 | 138614 | 138615 | 138616 | 138617 | 138618 | 138619 | 138620 | 138621 | 138622 | 138623 | 138624 | 138625 | 138626 | 138627 | 138628 | 138629 | 138630 | 138631 | 138632 | 138633 | 138634 | 138635 | 138636 | 138714 | 138715 | 138716 | 138717 | 138718 | 138719 | 138720 | 138721 | 138722 | 138723 | 138724 | 138725 | 138726 | 138727 | 138728 | 138729 | 138730 | 138731 | 138732 | 138733 | 138734 | 138735 | 138736 | 138773 | 138774 | 138775 | 138776 | 138777 | 138778 | 138779 | 138780 | 138781 | 138782 | 138783 | 138784 | 138785 | 138786 | 138787 | 138788 | 138789 | 138790 | 138791 | 138792 | 138793 | 138794 | 138832 | 139928