Bugzilla – Attachment 138862 Details for
Bug 30484
Interlibrary loans should have the ability to send notices based on request supplier updates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28909: (QA follow-up) Fix typo 'Kind Regards'
Bug-28909-QA-follow-up-Fix-typo-Kind-Regards.patch (text/plain), 6.89 KB, created by
Katrin Fischer
on 2022-08-08 21:01:35 UTC
(
hide
)
Description:
Bug 28909: (QA follow-up) Fix typo 'Kind Regards'
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-08-08 21:01:35 UTC
Size:
6.89 KB
patch
obsolete
>From 083e3a9ffdc10ea3445fab0bd68cf7b100b82ee8 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 8 Aug 2022 22:46:33 +0200 >Subject: [PATCH] Bug 28909: (QA follow-up) Fix typo 'Kind Regards' > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >https://bugs.koha-community.org/show_bug.cgi?id=30484 >--- > .../bug_30484-add-ill-update-notice.pl | 4 ++-- > .../data/mysql/en/mandatory/sample_notices.yml | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_30484-add-ill-update-notice.pl b/installer/data/mysql/atomicupdate/bug_30484-add-ill-update-notice.pl >index 06583df78c..42e8ebfaea 100755 >--- a/installer/data/mysql/atomicupdate/bug_30484-add-ill-update-notice.pl >+++ b/installer/data/mysql/atomicupdate/bug_30484-add-ill-update-notice.pl >@@ -6,8 +6,8 @@ return { > up => sub { > my ($args) = @_; > my ($dbh, $out) = @$args{qw(dbh out)}; >- $dbh->do(q{INSERT IGNORE INTO letter(module, code, branchcode, name, is_html, title, content, message_transport_type, lang) VALUES ('ill', 'ILL_REQUEST_UPDATE', '', 'ILL request update', 0, "Interlibrary loan request update", "Dear [% borrower.firstname %] [% borrower.surname %],\n\nThe Interlibrary loans request number [% illrequest.illrequest_id %] you placed for\n\n- [% ill_bib_title %] - [% ill_bib_author %]\n\nhas been updated\n\nDetails of the update are below:\n\n[% additional_text %]\n\nKind Regards\n\n[% branch.branchname %]\n[% branch.branchaddress1 %]\n[% branch.branchaddress2 %]\n[% branch.branchaddress3 %]\n[% branch.branchcity %]\n[% branch.branchstate %]\n[% branch.branchzip %]\n[% branch.branchphone %]\n[% branch.branchillemail %]\n[% branch.branchemail %]", 'email', 'default');}); >- $dbh->do(q{INSERT IGNORE INTO letter(module, code, branchcode, name, is_html, title, content, message_transport_type, lang) VALUES ('ill', 'ILL_REQUEST_UPDATE', '', 'ILL request update', 0, "Interlibrary loan request update", "Dear [% borrower.firstname %] [% borrower.surname %],\n\nThe Interlibrary loans request number [% illrequest.illrequest_id %] you placed for\n\n- [% ill_bib_title %] - [% ill_bib_author %]\n\nhas been updated\n\nDetails of the update are below:\n\n[% additional_text %]\n\nKind Regards\n\n[% branch.branchname %]\n[% branch.branchaddress1 %]\n[% branch.branchaddress2 %]\n[% branch.branchaddress3 %]\n[% branch.branchcity %]\n[% branch.branchstate %]\n[% branch.branchzip %]\n[% branch.branchphone %]\n[% branch.branchillemail %]\n[% branch.branchemail %]", 'sms', 'default');}); >+ $dbh->do(q{INSERT IGNORE INTO letter(module, code, branchcode, name, is_html, title, content, message_transport_type, lang) VALUES ('ill', 'ILL_REQUEST_UPDATE', '', 'ILL request update', 0, "Interlibrary loan request update", "Dear [% borrower.firstname %] [% borrower.surname %],\n\nThe Interlibrary loans request number [% illrequest.illrequest_id %] you placed for\n\n- [% ill_bib_title %] - [% ill_bib_author %]\n\nhas been updated\n\nDetails of the update are below:\n\n[% additional_text %]\n\nKind regards\n\n[% branch.branchname %]\n[% branch.branchaddress1 %]\n[% branch.branchaddress2 %]\n[% branch.branchaddress3 %]\n[% branch.branchcity %]\n[% branch.branchstate %]\n[% branch.branchzip %]\n[% branch.branchphone %]\n[% branch.branchillemail %]\n[% branch.branchemail %]", 'email', 'default');}); >+ $dbh->do(q{INSERT IGNORE INTO letter(module, code, branchcode, name, is_html, title, content, message_transport_type, lang) VALUES ('ill', 'ILL_REQUEST_UPDATE', '', 'ILL request update', 0, "Interlibrary loan request update", "Dear [% borrower.firstname %] [% borrower.surname %],\n\nThe Interlibrary loans request number [% illrequest.illrequest_id %] you placed for\n\n- [% ill_bib_title %] - [% ill_bib_author %]\n\nhas been updated\n\nDetails of the update are below:\n\n[% additional_text %]\n\nKind regards\n\n[% branch.branchname %]\n[% branch.branchaddress1 %]\n[% branch.branchaddress2 %]\n[% branch.branchaddress3 %]\n[% branch.branchcity %]\n[% branch.branchstate %]\n[% branch.branchzip %]\n[% branch.branchphone %]\n[% branch.branchillemail %]\n[% branch.branchemail %]", 'sms', 'default');}); > $dbh->do(q{INSERT IGNORE INTO message_attributes (message_name, takes_days) VALUES ('Ill_update', 0);}); > my $ready_id = $dbh->last_insert_id(undef, undef, 'message_attributes', undef); > if (defined $ready_id) { >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index ebe2a38715..9c3edd4c43 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -739,7 +739,7 @@ tables: > - "" > - "is ready for pick up from [% branch.branchname %]." > - "" >- - "Kind Regards" >+ - "Kind regards" > - "" > - "[% branch.branchname %]" > - "[% branch.branchaddress1 %]" >@@ -769,7 +769,7 @@ tables: > - "" > - "is unfortunately unavailable." > - "" >- - "Kind Regards" >+ - "Kind regards" > - "" > - "[% branch.branchname %]" > - "[% branch.branchaddress1 %]" >@@ -825,7 +825,7 @@ tables: > - "" > - "Please let us know if you are able to supply this to us." > - "" >- - "Kind Regards" >+ - "Kind regards" > - "" > - "[% branch.branchname %]" > - "[% branch.branchaddress1 %]" >@@ -859,7 +859,7 @@ tables: > - "" > - "[% additional_text %]" > - "" >- - "Kind Regards" >+ - "Kind regards" > - "" > - "[% branch.branchname %]" > - "[% branch.branchaddress1 %]" >@@ -889,7 +889,7 @@ tables: > - "" > - "is ready for pick up from [% branch.branchname %]." > - "" >- - "Kind Regards" >+ - "Kind regards" > - "" > - "[% branch.branchname %]" > - "[% branch.branchaddress1 %]" >@@ -919,7 +919,7 @@ tables: > - "" > - "is unfortunately unavailable." > - "" >- - "Kind Regards" >+ - "Kind regards" > - "" > - "[% branch.branchname %]" > - "[% branch.branchaddress1 %]" >@@ -975,7 +975,7 @@ tables: > - "" > - "Please let us know if you are able to supply this to us." > - "" >- - "Kind Regards" >+ - "Kind regards" > - "" > - "[% branch.branchname %]" > - "[% branch.branchaddress1 %]" >@@ -1009,7 +1009,7 @@ tables: > - "" > - "[% additional_text %]" > - "" >- - "Kind Regards" >+ - "Kind regards" > - "" > - "[% branch.branchname %]" > - "[% branch.branchaddress1 %]" >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30484
:
133394
|
133395
|
133396
|
133399
|
133400
|
133401
|
134486
|
134487
|
134488
|
134569
|
134570
|
134571
|
134572
|
134573
|
134574
|
134626
|
134627
|
134628
|
138859
|
138860
|
138861
| 138862