Attachment 138920 Details for Bug 31307 – Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl

[patch] Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl

Bug-31307-Remove-alreadyreserved-flag-from-opac-re.patch (text/plain), 1.20 KB, created by Nick Clemens (kidclamp) on 2022-08-09 14:51:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-08-09 14:51:45 UTC

Size: 1.20 KB

patch

obsolete

>From 82217c30d65224778dc5206b253c70d26903496f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 3 Jun 2022 07:32:35 +0200
>Subject: [PATCH] Bug 31307: Remove 'already_reserved' flag from
> opac-reserve.pl
>
>It was never set (was set before 14695)
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> opac/opac-reserve.pl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index e5c2753d6c..1c210684c5 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -563,10 +563,9 @@ foreach my $biblioNum (@biblionumbers) {
>         my $patron_unblessed = $patron->unblessed;
>         my $branch = GetReservesControlBranch( $itemInfo, $patron_unblessed );
> 
>-        my $policy_holdallowed = !$itemLoopIter->{already_reserved};
>         # items_any_available defined outside of the current loop,
>         # so we avoiding loop inside IsAvailableForItemLevelRequest:
>-        $policy_holdallowed &&=
>+        my $policy_holdallowed =
>             CanItemBeReserved( $patron, $item )->{status} eq 'OK' &&
>             IsAvailableForItemLevelRequest($item, $patron, undef, $items_any_available);
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31307: 138834 | 138920