Attachment 138923 Details for Bug 28909 – Bug 28909: Fix handling if backend doesn't support

[patch] Bug 28909: Fix handling if backend doesn't support

Bug-28909-Fix-handling-if-backend-doesnt-support.patch (text/plain), 1.81 KB, created by Martin Renvoize (ashimema) on 2022-08-09 15:22:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-08-09 15:22:57 UTC

Size: 1.81 KB

patch

obsolete

>From e5d52417ab7868af9fb3adff5537f2923b96e37f Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Tue, 31 Aug 2021 10:06:03 +0100
>Subject: [PATCH] Bug 28909: Fix handling if backend doesn't support
>
>If a backend hasn't been updated to support this functionality, we need
>to handle that gracefully
>
>Also, this commit fixes some indentation.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Illrequest.pm                                          | 6 +++---
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 2 ++
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index 540a3efe46..4f50a425df 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -722,9 +722,9 @@ sub backend_illview {
>     my ( $self, $params ) = @_;
> 
>     my $response = $self->_backend_capability('illview',{
>-            request    => $self,
>-            other      => $params,
>-        });
>+        request    => $self,
>+        other      => $params,
>+    });
>     return $self->expandTemplate($response) if $response;
>     return $response;
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 0933b1a7c5..c27fe0e1a4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -484,7 +484,9 @@
>                     </div>
> 
>                 [% ELSIF query_type == 'illview' %]
>+                    [% IF whole.template.length > 0 %]
>                     [% PROCESS $whole.template %]
>+                    [% END %]
>                     [% req_status = request.status %]
> 
>                     [% IF error %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28909: 124174 | 124270 | 124271 | 129102 | 129103 | 129104 | 138856 | 138857 | 138858 | 138922 | 138923