Bugzilla – Attachment 138970 Details for
Bug 31335
Unnecessary holds fetch in serials/routing-preview.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31335: Remove unnecessary holds fetch from routing-preview
Bug-31335-Remove-unnecessary-holds-fetch-from-rout.patch (text/plain), 1.13 KB, created by
Jonathan Druart
on 2022-08-10 10:35:29 UTC
(
hide
)
Description:
Bug 31335: Remove unnecessary holds fetch from routing-preview
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-08-10 10:35:29 UTC
Size:
1.13 KB
patch
obsolete
>From a0dde08eac4f67c580ea262a12165849d9dbbb1a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 10 Aug 2022 12:10:00 +0200 >Subject: [PATCH] Bug 31335: Remove unnecessary holds fetch from > routing-preview > >This $count variable is not used later, and I didn't find why it was >there in previous versions. > >Test plan: >Use `git log -p serials/routing-preview.pl` and confirm we can remove >this block >--- > serials/routing-preview.pl | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/serials/routing-preview.pl b/serials/routing-preview.pl >index 61e0e9db4a7..e12cd17af0d 100755 >--- a/serials/routing-preview.pl >+++ b/serials/routing-preview.pl >@@ -73,13 +73,6 @@ if($ok){ > $library = Koha::Libraries->find($branchcode); > > if (C4::Context->preference('RoutingListAddReserves')){ >- # get existing reserves ..... >- >- my $holds = $biblio->current_holds; >- my $count = $holds->count; >- while ( my $hold = $holds->next ) { >- $count-- if $hold->is_waiting; >- } > my $notes; > my $title = $subs->{'bibliotitle'}; > for my $routing ( @routinglist ) { >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31335
:
138970
|
163525
|
164594