Bugzilla – Attachment 139032 Details for
Bug 31346
On the OPAC detail page some Syndetics links are wrong
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31346: Fix broken Syndetics links on OPAC detail page
Bug-31346-Fix-broken-Syndetics-links-on-OPAC-detai.patch (text/plain), 8.53 KB, created by
Lucas Gass (lukeg)
on 2022-08-11 23:00:45 UTC
(
hide
)
Description:
Bug 31346: Fix broken Syndetics links on OPAC detail page
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2022-08-11 23:00:45 UTC
Size:
8.53 KB
patch
obsolete
>From 172178f9a1ba7a64a9d228112878d879d30867f9 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 11 Aug 2022 22:56:49 +0000 >Subject: [PATCH] Bug 31346: Fix broken Syndetics links on OPAC detail page > >To test: >-Have some Syndetics credentials >-Turn on SyndeticsCoverImages >-Look at some and you'll notice that Syndetics cover images dont always load >-If you view the page source you'll see why. The links are built like this: >https://secure.syndetics.com/index.aspx?isbn=/LC.GIF&amp;client=bedf&type=xw10&upc=843501038123&oclc=1311289389 > >-Apply patch >-Cover images should load properly. >--- > .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index b3607465d8..5f723b8af1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -85,8 +85,8 @@ > [% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %] > [% IF ( content_identifier_exists ) %] > <div class="cover-image" id="syndetics-coverimg"> >- <a href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | uri %]/[% SyndeticsCoverImageSize | uri %].GIF&amp;client=[% SyndeticsClientCode | uri %]&type=xw10&upc=[% normalized_upc | uri %]&oclc=[% normalized_oclc | uri %]" title="Syndetics cover image"> >- <img src="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | uri %]/[% SyndeticsCoverImageSize | uri %].GIF&amp;client=[% SyndeticsClientCode | uri %]&type=xw10&upc=[% normalized_upc | uri %]&oclc=[% normalized_oclc | uri %]" alt="Syndetics cover image" /> >+ <a href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | uri %]/[% SyndeticsCoverImageSize | uri %].GIF&client=[% SyndeticsClientCode | uri %]&type=xw10&upc=[% normalized_upc | uri %]&oclc=[% normalized_oclc | uri %]" title="Syndetics cover image"> >+ <img src="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | uri %]/[% SyndeticsCoverImageSize | uri %].GIF&client=[% SyndeticsClientCode | uri %]&type=xw10&upc=[% normalized_upc | uri %]&oclc=[% normalized_oclc | uri %]" alt="Syndetics cover image" /> > </a> > <div class="hint">Image from Syndetics</div> > </div> >@@ -268,27 +268,27 @@ > [% IF ( SyndeticsSeries && SyndeticsSERIES1Exists ) %] > <span class="results_summary"> > <span class="label">Series information:</span> >- <a target="_blank" rel="noreferrer" href="https://secure.syndetics.com/ffseries.aspx?isbn=[% normalized_isbn | html %]&type=series&num=1&client=[% SyndeticsClientCode | html %][% IF ( normalized_upc ) %]&upc=[% normalized_upc | html %][% END %][% IF ( normalized_oclc ) %]&oclc=[% normalized_oclc | html %][% END %]">Click to open in new window</a> >+ <a target="_blank" rel="noreferrer" href="https://secure.syndetics.com/ffseries.aspx?isbn=[% normalized_isbn | uri %]&type=series&num=1&client=[% SyndeticsClientCode | uri %][% IF ( normalized_upc ) %]&upc=[% normalized_upc | uri %][% END %][% IF ( normalized_oclc ) %]&oclc=[% normalized_oclc | uri %][% END %]">Click to open in new window</a> > </span> > [% END # / IF SyndeticsSeries && SyndeticsSERIES1Exists%] > [% IF ( SyndeticsAVPROFILEExists ) %] > <span class="results_summary"> > <span class="label">Audiovisual profile:</span> >- <a target="_blank" rel="noreferrer" href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | html %]/avprofile.html&client=[% SyndeticsClientCode | html %][% IF ( normalized_upc ) %]&upc=[% normalized_upc | html %][% END %][% IF ( normalized_oclc ) %]&oclc=[% normalized_oclc | html %][% END %]&type=xw10">Click to open in new window</a> >+ <a target="_blank" rel="noreferrer" href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | uri %]/avprofile.html&client=[% SyndeticsClientCode | uri %][% IF ( normalized_upc ) %]&upc=[% normalized_upc | uri %][% END %][% IF ( normalized_oclc ) %]&oclc=[% normalized_oclc | uri %][% END %]&type=xw10">Click to open in new window</a> > </span> > [% END # / IF SyndeticsAVPROFILEExists %] > > [% IF ( SyndeticsFICTIONExists ) %] > <span class="results_summary"> > <span class="label">Fiction notes:</span> >- <a target="_blank" rel="noreferrer" href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | html %]/fiction.html&client=[% SyndeticsClientCode | html %][% IF ( normalized_upc ) %]&upc=[% normalized_upc | html %][% END %][% IF ( normalized_oclc ) %]&oclc=[% normalized_oclc | html %][% END %]&type=xw10">Click to open in new window</a> >+ <a target="_blank" rel="noreferrer" href="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | uri %]/fiction.html&client=[% SyndeticsClientCode | uri %][% IF ( normalized_upc ) %]&upc=[% normalized_upc | uri %][% END %][% IF ( normalized_oclc ) %]&oclc=[% normalized_oclc | uri %][% END %]&type=xw10">Click to open in new window</a> > </span> > [% END # / IF SyndeticsFICTIONExists %] > > [% IF ( SyndeticsAwards && SyndeticsAWARDS1Exists ) %] > <span class="results_summary"> > <span class="label">Awards:</span> >- <a target="_blank" rel="noreferrer" href="https://secure.syndetics.com/ffawards.aspx?isbn=[% normalized_isbn | html %]&type=awards&client=[% SyndeticsClientCode | html %][% IF ( normalized_upc ) %]&upc=[% normalized_upc | html %][% END %][% IF ( normalized_oclc ) %]&oclc=[% normalized_oclc | html %][% END %]">Click to open in new window</a> >+ <a target="_blank" rel="noreferrer" href="https://secure.syndetics.com/ffawards.aspx?isbn=[% normalized_isbn | uri %]&type=awards&client=[% SyndeticsClientCode | uri %][% IF ( normalized_upc ) %]&upc=[% normalized_upc | uri %][% END %][% IF ( normalized_oclc ) %]&oclc=[% normalized_oclc | uri %][% END %]">Click to open in new window</a> > </span> > [% END # / IF SyndeticsAwards && SyndeticsAWARDS1Exists %] > [% END # / IF SyndeticsEnabled%] >@@ -900,7 +900,7 @@ > > [% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %] > [% IF ( XISBN.content_identifier_exists ) %] >- <img src="https://secure.syndetics.com/index.aspx?isbn=[% XISBN.browser_normalized_isbn | html %]/SC.GIF&client=[% SyndeticsClientCode | html %][% IF ( XISBN.browser_normalized_upc ) %]&upc=[% XISBN.browser_normalized_upc | html %][% END %][% IF ( XISBN.browser_normalized_oclc ) %]&oclc=[% XISBN.browser_normalized_oclc | html %][% END %]&type=xw10" alt="" /> >+ <img src="https://secure.syndetics.com/index.aspx?isbn=[% XISBN.browser_normalized_isbn | uri %]/SC.GIF&client=[% SyndeticsClientCode | uri %][% IF ( XISBN.browser_normalized_upc ) %]&upc=[% XISBN.browser_normalized_upc | uri %][% END %][% IF ( XISBN.browser_normalized_oclc ) %]&oclc=[% XISBN.browser_normalized_oclc | uri %][% END %]&type=xw10" alt="" /> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END # / IF XISBN.content_identifier_exists %] >-- >2.30.2
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=139032">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31346
:
139032
|
139059
|
139060