Attachment 139048 Details for Bug 31343 – Bug 31343: (bug 31138 follow-up) Don't hide error

[patch] Bug 31343: (bug 31138 follow-up) Don't hide error

Bug-31343-bug-31138-follow-up-Dont-hide-error.patch (text/plain), 1.10 KB, created by Jonathan Druart on 2022-08-12 13:20:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-08-12 13:20:25 UTC

Size: 1.10 KB

patch

obsolete

>From a8b2a71f751b984fc7edc5d156e0acc0b393289f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 12 Aug 2022 15:17:45 +0200
>Subject: [PATCH] Bug 31343: (bug 31138 follow-up) Don't hide error
>
>Some errors are not passing settings and so the error is hidden
>---
> koha-tmpl/intranet-tmpl/prog/js/datatables.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index 9f62aa2270b..e97f6fa3d34 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -485,7 +485,7 @@ function filterDataTable( table, column, term ){
> }
> 
> jQuery.fn.dataTable.ext.errMode = function(settings, note, message) {
>-    if ( settings.jqXHR ) {
>+    if ( settings && settings.jqXHR ) {
>         console.log("Got %s (%s)".format(settings.jqXHR.status, settings.jqXHR.statusText));
>         alert(__("Something went wrong when loading the table.\n%s: %s").format(settings.jqXHR.status, settings.jqXHR.statusText));
>     } else {
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 31343: 139048 | 139049 | 139053 | 139054 | 139499 | 139500