Attachment 139084 Details for Bug 30718 – Bug 30718: Fix renewal with due date

[patch] Bug 30718: Fix renewal with due date

Bug-30718-Fix-renewal-with-due-date.patch (text/plain), 1.13 KB, created by Victor Grousset/tuxayo on 2022-08-12 21:21:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2022-08-12 21:21:48 UTC

Size: 1.13 KB

patch

obsolete

>From 84e1d2fb2ba221b33a414a70c0a5377cd4c06ea1 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 9 Aug 2022 08:41:37 +0200
>Subject: [PATCH] Bug 30718: Fix renewal with due date
>
>This was a test added by the following commit:
>
>commit 99eccc18ed4a21fa416a3d61fed3f70825dc2203
>Date:   Thu Jun 16 10:10:09 2011 +0100
>    Bug 5549 : Handle datetimes on return
>
>It's no longer needed now, we can pass a DateTime or an ISO-formatted
>date
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> C4/Circulation.pm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 65b8ddf256..7b028bed0f 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3094,8 +3094,7 @@ sub AddRenewal {
>     $borrowernumber ||= $issue->borrowernumber;
> 
>     if ( defined $datedue && ref $datedue ne 'DateTime' ) {
>-        carp 'Invalid date passed to AddRenewal.';
>-        return;
>+        $datedue = dt_from_string($datedue, 'sql');
>     }
> 
>     my $patron = Koha::Patrons->find( $borrowernumber ) or return; # FIXME Should do more than just return
>-- 
>2.37.1

Actions: View | Diff | Splinter Review

Attachments on bug 30718: 135487 | 137516 | 137707 | 137715 | 137803 | 137804 | 137805 | 137806 | 137807 | 137868 | 137869 | 138644 | 138645 | 138646 | 138647 | 138648 | 138649 | 138650 | 138651 | 138652 | 138658 | 138659 | 138748 | 138749 | 138750 | 138751 | 138752 | 138753 | 138754 | 138755 | 138756 | 138757 | 138758 | 138879 | 138980 | 139033 | 139073 | 139074 | 139075 | 139076 | 139077 | 139078 | 139079 | 139080 | 139081 | 139082 | 139083 | 139084 | 139085 | 139453 | 139454 | 139455 | 139456 | 139457 | 139458 | 139459 | 139460 | 139461 | 139462 | 139463 | 139464 | 139465 | 139466 | 139467 | 139468 | 139490 | 139605 | 143175