Bugzilla – Attachment 139092 Details for
Bug 31310
Remove GetItemsInfo from catalogue/imageviewer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31310: Remove GetItemsInfo from catalogue/imageviewer
Bug-31310-Remove-GetItemsInfo-from-catalogueimagev.patch (text/plain), 1.55 KB, created by
Joonas Kylmälä
on 2022-08-14 13:56:34 UTC
(
hide
)
Description:
Bug 31310: Remove GetItemsInfo from catalogue/imageviewer
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2022-08-14 13:56:34 UTC
Size:
1.55 KB
patch
obsolete
>From 81eee052277938d7a4a86a2e84353cc3777084a1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 2 Jun 2022 11:34:46 +0200 >Subject: [PATCH] Bug 31310: Remove GetItemsInfo from catalogue/imageviewer >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. > >Here we are going to deal with catalogue/imageviewer > >Test plan: >List items on the modified view and confirm that all the info is >displayed correctly > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > catalogue/imageviewer.pl | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/catalogue/imageviewer.pl b/catalogue/imageviewer.pl >index 1fc1f42304..fc65a1ac07 100755 >--- a/catalogue/imageviewer.pl >+++ b/catalogue/imageviewer.pl >@@ -21,7 +21,6 @@ use Modern::Perl; > > use CGI qw ( -utf8 ); > use C4::Auth qw( get_template_and_user ); >-use C4::Items qw( GetItemsInfo ); > use C4::Output qw( output_html_with_http_headers ); > use C4::Search qw( enabled_staff_search_views ); > >@@ -44,7 +43,6 @@ my $biblionumber = $query->param('biblionumber') || $query->param('bib') || Koha > my $imagenumber = $query->param('imagenumber'); > my $biblio = Koha::Biblios->find( $biblionumber ); > my $itemcount = $biblio ? $biblio->items->count : 0; >-my @items = GetItemsInfo($biblionumber); > > if ( $query->cookie("holdfor") ) { > my $holdfor_patron = Koha::Patrons->find( $query->cookie("holdfor") ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31310
:
138818
|
138844
| 139092