Bugzilla – Attachment 139093 Details for
Bug 31317
Remove GetItemsInfo from opac-tags
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31317: Remove GetItemsInfo import from opac-tags
Bug-31317-Remove-GetItemsInfo-import-from-opac-tag.patch (text/plain), 1.63 KB, created by
Joonas Kylmälä
on 2022-08-14 14:14:54 UTC
(
hide
)
Description:
Bug 31317: Remove GetItemsInfo import from opac-tags
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2022-08-14 14:14:54 UTC
Size:
1.63 KB
patch
obsolete
>From f745f09d35fc17fc9dcfa80eeff1ce99ad89e0e2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 3 Jun 2022 08:23:55 +0200 >Subject: [PATCH] Bug 31317: Remove GetItemsInfo import from opac-tags >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. > >Here we are going to deal with opac-tags > >Test plan: >List items on the modified view and confirm that all the info is >displayed correctly > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > opac/opac-tags.pl | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/opac/opac-tags.pl b/opac/opac-tags.pl >index e75f86c5a3..4aec61ee73 100755 >--- a/opac/opac-tags.pl >+++ b/opac/opac-tags.pl >@@ -40,7 +40,6 @@ use C4::Auth qw( check_cookie_auth get_template_and_user ); > use C4::Context; > use C4::Output qw( output_with_http_headers is_ajax output_html_with_http_headers ); > use C4::Scrubber; >-use C4::Items qw( GetItemsInfo ); > use C4::Tags qw( > add_tag > get_approval_rows >@@ -261,7 +260,7 @@ if ($loggedinuser) { > next unless $record; > my @hidden_items; > if ($should_hide) { >- my $items = $biblio->items; >+ my $items = $biblio->items->search_ordered; > my @all_itemnumbers = $items->get_column('itemnumber'); > my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron })->as_list; > @hidden_items = array_minus( @all_itemnumbers, @items_to_show ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31317
:
138827
|
138900
| 139093