Attachment 139127 Details for Bug 29697 – Bug 29697: (follow-up) Check against itemnumbers for visibility

[patch] Bug 29697: (follow-up) Check against itemnumbers for visibility

Bug-29697-follow-up-Check-against-itemnumbers-for-.patch (text/plain), 1.11 KB, created by Nick Clemens (kidclamp) on 2022-08-15 12:27:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-08-15 12:27:51 UTC

Size: 1.11 KB

patch

obsolete

>From d7f6436290668537e20760ff1c4dbfae76c1a14e Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 15 Aug 2022 12:25:40 +0000
>Subject: [PATCH] Bug 29697: (follow-up) Check against itemnumbers for
> visibility
>
>No items are shoing on the opac because we are comparing the itemnumber to an object
>
>This patch simplies check against the itemnumber
>
>Note: With this the inclusion of host_items it still broken as they won't be in the
>visible items list
>
>Bug 31313 will fix this completely
>---
> opac/opac-detail.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 06d7044942..7a60e57e29 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -521,7 +521,7 @@ my @items;
> # Hide items
> if ( @items_to_show != @all_items ) {
>     for my $itm (@all_items) {
>-        next unless any { $itm->{itemnumber} eq $_ } @items_to_show;
>+        next unless any { $itm->{itemnumber} eq $_->itemnumber } @items_to_show;
>         if ( C4::Context->preference('hidelostitems') ) {
>             push @items, $itm unless $itm->{itemlost};
>         }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29697: 129757 | 129758 | 129759 | 129760 | 129761 | 131868 | 131869 | 131870 | 131871 | 131872 | 131873 | 134066 | 134067 | 134068 | 134069 | 134070 | 134071 | 135574 | 135575 | 135576 | 135577 | 135578 | 135579 | 135580 | 135662 | 135663 | 135664 | 135665 | 135666 | 135667 | 135668 | 135669 | 135670 | 135671 | 135672 | 135673 | 135797 | 135798 | 135799 | 135800 | 135801 | 135802 | 135978 | 135979 | 135980 | 135981 | 135982 | 137835 | 137836 | 137837 | 137838 | 137839 | 137840 | 137894 | 137918 | 137919 | 137920 | 137921 | 137922 | 137923 | 137924 | 137948 | 138057 | 138076 | 138077 | 138078 | 138079 | 138080 | 138081 | 138089 | 138090 | 138804 | 139127 | 140007 | 140008