Attachment 139244 Details for Bug 23202 – Bug 23202: Fix screen freeze when ordereing several items

[patch] Bug 23202: Fix screen freeze when ordereing several items

Bug-23202-Fix-screen-freeze-when-ordereing-several.patch (text/plain), 1.85 KB, created by Jonathan Druart on 2022-08-17 09:45:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-08-17 09:45:32 UTC

Size: 1.85 KB

patch

obsolete

>From 188168f7e4039b68099680a3b9c1358fe5a654d9 Mon Sep 17 00:00:00 2001
>From: Johanna Raisa <johanna.raisa@gmail.com>
>Date: Tue, 26 Jul 2022 12:01:56 +0300
>Subject: [PATCH] Bug 23202: Fix screen freeze when ordereing several items
>
>This patch fixes adding multiple items on order acquisitions
>
>The error is: Uncaught TypeError: $(...).parent(...).attr(...) is undefined
>
>Test plan:
>1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field.
>2) Create basket to a vendor and add order from a new empty record.
>3) Add date acquired value from calendar.
>4) Add multiple items and see that the view freezes.
>5) Apply the patch
>6) Reload the page and repeat the steps 3 and 4.
>7) See that the items are added.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>JD Amended patch: adjust commit title
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/js/additem.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/additem.js b/koha-tmpl/intranet-tmpl/prog/js/additem.js
>index a83310f29d4..fac6b2648cf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/additem.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/additem.js
>@@ -192,7 +192,7 @@ function cloneItemBlock(index, unique_item_fields, callback) {
>             $(original).find("input[name='field_value']").each(function(){
>                 var kohafield = $(this).siblings("input[name='kohafield']").val();
>                 if($(this).val() && $.inArray(kohafield,dont_copy_fields) == -1) {
>-                    $(this).parent("div").attr("id").match(/^(subfield.)/);
>+                    $(this).closest("li div").attr("id").match(/^(subfield.)/);
>                     var id = RegExp.$1;
>                     var value = $(this).val();
>                     $(clone).find("div[id^='"+id+"'] input[name='field_value']").val(value);
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 23202: 138120 | 138395 | 139244