Bugzilla – Attachment 139371 Details for
Bug 29144
Move branches.opac_info to AdditionalContents allowing multi language
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29144: Remove opac_info from GetItemsInfo
Bug-29144-Remove-opacinfo-from-GetItemsInfo.patch (text/plain), 2.33 KB, created by
Martin Renvoize (ashimema)
on 2022-08-18 12:54:40 UTC
(
hide
)
Description:
Bug 29144: Remove opac_info from GetItemsInfo
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-08-18 12:54:40 UTC
Size:
2.33 KB
patch
obsolete
>From 7cfea3d5a15dd81c6d6fe894fb7396e9e211e60c Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 3 Aug 2022 11:55:59 +0000 >Subject: [PATCH] Bug 29144: Remove opac_info from GetItemsInfo > >Test plan: >Run t/db_dependent/Items.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Items.pm | 2 -- > t/db_dependent/Items.t | 14 +------------- > 2 files changed, 1 insertion(+), 15 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 443242be5d..5cfdb2d5c4 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -750,8 +750,6 @@ sub GetItemsInfo { > holding.branchurl, > holding.branchcode, > holding.branchname, >- holding.opac_info as holding_branch_opac_info, >- home.opac_info as home_branch_opac_info, > IF(tmp_holdsqueue.itemnumber,1,0) AS has_pending_hold > FROM items > LEFT JOIN branches AS holding ON items.holdingbranch = holding.branchcode >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index c39a0b963f..c8d4a0f7db 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -192,7 +192,7 @@ subtest 'ModItemTransfer tests' => sub { > > subtest 'GetItemsInfo tests' => sub { > >- plan tests => 9; >+ plan tests => 7; > > $schema->storage->txn_begin; > >@@ -230,21 +230,9 @@ subtest 'GetItemsInfo tests' => sub { > } > )->itemnumber; > >- my $library = Koha::Libraries->find( $library1->{branchcode} ); >- $library->opac_info("homebranch OPAC info"); >- $library->store; >- >- $library = Koha::Libraries->find( $library2->{branchcode} ); >- $library->opac_info("holdingbranch OPAC info"); >- $library->store; >- > my @results = GetItemsInfo( $biblio->biblionumber ); > ok( @results, 'GetItemsInfo returns results'); > >- is( $results[0]->{ home_branch_opac_info }, "homebranch OPAC info", >- 'GetItemsInfo returns the correct home branch OPAC info notice' ); >- is( $results[0]->{ holding_branch_opac_info }, "holdingbranch OPAC info", >- 'GetItemsInfo returns the correct holding branch OPAC info notice' ); > is( exists( $results[0]->{ onsite_checkout } ), 1, > 'GetItemsInfo returns a onsite_checkout key' ); > is( $results[0]->{ restricted }, 1, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29144
:
138473
|
138474
|
138527
|
138528
|
138599
|
138600
|
138601
|
138602
|
138603
|
138604
|
138605
|
138606
|
138607
|
138608
|
138609
|
139182
|
139183
|
139184
|
139185
|
139186
|
139187
|
139188
|
139189
|
139190
|
139191
|
139192
|
139197
|
139198
|
139199
|
139200
|
139201
|
139202
|
139203
|
139204
|
139205
|
139206
|
139207
|
139208
|
139366
|
139367
|
139368
|
139369
|
139370
|
139371
|
139372
|
139373
|
139374
|
139375
|
139376
|
139377
|
140020
|
140021
|
140022
|
140023
|
140024
|
140025
|
140026
|
140027
|
140028
|
140029
|
140030
|
140707