Attachment 13939 Details for Bug 9049 – [Signed-Off] [Passed-QA] Bug 9049: Don't use shadow with rebuild_zebra -r

[patch] [Signed-Off] [Passed-QA] Bug 9049: Don't use shadow with rebuild_zebra -r

Signed-Off-Passed-QA-Bug-9049-Dont-use-shadow-with.patch (text/plain), 1.90 KB, created by Elliott Davis on 2012-12-07 16:43:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Elliott Davis

Created: 2012-12-07 16:43:09 UTC

Size: 1.90 KB

patch

obsolete

>From 5a89a9d84ab0ee22d4b8e42943a5981521e212c1 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Sat, 10 Nov 2012 07:51:22 -0500
>Subject: [PATCH] [Signed-Off] [Passed-QA] Bug 9049: Don't use shadow with rebuild_zebra -r
>
>Due to a limitation of Zebra, the register must be cleared *before*
>doing shadow indexing if you want to reset the indexes. In light of
>that, it does not make sense to do shadow indexing at all when
>rebuild_zebra.pl is run with the -r switch. This patch makes -r (reset)
>imply -n (no shadow).
>
>To test:
>1) Run `rebuild_zebra.pl -b -r -v -v -v`
>2) Note that the script never runs the merge phase
>
>Without the patch I see log lines refering to the shadow cache (enabling shadow spec=/home/koha/koha-dev/var/lib/zebradb/biblios/shadow:20G)
>With the patch I don't see anything in the logs about shadow.  I do however see lines about merging.  I think it could just be a misunderstanding of the logs
>
>Signed-off-by: wajasu <matted-34813@mypacks.net>
>Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
>---
> misc/migration_tools/rebuild_zebra.pl |    6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>diff --git a/misc/migration_tools/rebuild_zebra.pl b/misc/migration_tools/rebuild_zebra.pl
>index 0e24df5..b72ab2c 100755
>--- a/misc/migration_tools/rebuild_zebra.pl
>+++ b/misc/migration_tools/rebuild_zebra.pl
>@@ -93,6 +93,10 @@ if ($process_zebraqueue and $do_not_clear_zebraqueue) {
>     die $msg;
> }
> 
>+if ($reset) {
>+    $noshadow = 1;
>+}
>+
> if ($noshadow) {
>     $noshadow = ' -n ';
> }
>@@ -667,7 +671,7 @@ Parameters:
>                             or -s.
> 
>     -r                      clear Zebra index before
>-                            adding records to index
>+                            adding records to index. Implies -w.
> 
>     -d                      Temporary directory for indexing.
>                             If not specified, one is automatically
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 9049: 13372 | 13637 | 13939