Bugzilla – Attachment 13942 Details for
Bug 9140
Untranslatable strings in item circulation history
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9140: Followup removes the useless variable $message
Bug-9140-Followup-removes-the-useless-variable-mes.patch (text/plain), 2.29 KB, created by
Kyle M Hall (khall)
on 2012-12-07 16:57:14 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9140: Followup removes the useless variable $message
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-12-07 16:57:14 UTC
Size:
2.29 KB
patch
obsolete
>From 3ca59c650dd776039d4fff40c0c66a47cbd9581a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 4 Dec 2012 16:56:54 +0100 >Subject: [PATCH] Bug 9140: Followup removes the useless variable $message > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > circ/bookcount.pl | 14 +++++--------- > 1 files changed, 5 insertions(+), 9 deletions(-) > >diff --git a/circ/bookcount.pl b/circ/bookcount.pl >index 8405ff2..75bf319 100755 >--- a/circ/bookcount.pl >+++ b/circ/bookcount.pl >@@ -45,12 +45,11 @@ my $data = GetBiblioItemData($bi); > my $homebranch = $branches->{ $idata->{'homebranch'} }->{'branchname'}; > my $holdingbranch = $branches->{ $idata->{'holdingbranch'} }->{'branchname'}; > >-my ( $lastmove, $message ) = lastmove($itm); >+my $lastmove = lastmove($itm); > > my $lastdate; > my $count; > if ( not $lastmove ) { >-# $lastdate = $message; > $count = issuessince( $itm, 0 ); > } else { > $lastdate = $lastmove->{'datearrived'}; >@@ -79,8 +78,6 @@ foreach (@$branchloop) { > $_->{seentime} = $timechunk; > } > >-### $lastdate >- > $template->param( > biblionumber => $biblionumber, > title => $data->{'title'}, >@@ -112,14 +109,14 @@ sub lastmove { > ); > $sth->execute($itemnumber); > my ($date) = $sth->fetchrow_array; >- return ( 0, 1 ) if not $date; >+ return 0 unless $date; > $sth = $dbh->prepare( > "SELECT * FROM branchtransfers WHERE branchtransfers.itemnumber=? and branchtransfers.datearrived=?" > ); > $sth->execute( $itemnumber, $date ); > my ($data) = $sth->fetchrow_hashref; >- return ( 0, 1 ) if not $data; >- return ( $data, "" ); >+ return 0 unless $data; >+ return $data; > } > > sub issuessince { >@@ -165,7 +162,7 @@ sub lastseenat { > "SELECT MAX(transfer) FROM (SELECT max(datearrived) AS transfer FROM branchtransfers WHERE itemnumber=? AND tobranch = ? > UNION ALL > SELECT max(datesent) AS transfer FROM branchtransfers WHERE itemnumber=? AND frombranch = ? >- ) tmp" >+ ) tmp" > ); > $sth->execute( $itm, $brc, $itm, $brc ); > my ($date2) = $sth->fetchrow_array; >@@ -179,7 +176,6 @@ sub lastseenat { > sub slashdate { > my ($date) = @_; > $date or return; >- # warn "slashdate($date)..."; > return ( > format_date($date), > substr($date,11,5) >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9140
:
13663
|
13682
|
13880
|
13941
|
13942
|
14237
|
14238
|
14239