Bugzilla – Attachment 139494 Details for
Bug 31112
Able to renew checkout when the number of holds exceeds available number of items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31112: (QA follow-up) Restore check to avoid extra processing
Bug-31112-QA-follow-up-Restore-check-to-avoid-extr.patch (text/plain), 957 bytes, created by
Nick Clemens (kidclamp)
on 2022-08-19 13:43:13 UTC
(
hide
)
Description:
Bug 31112: (QA follow-up) Restore check to avoid extra processing
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-08-19 13:43:13 UTC
Size:
957 bytes
patch
obsolete
>From 3d64757140b6d568896ddeed78da9677c540093b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 19 Aug 2022 13:11:09 +0000 >Subject: [PATCH] Bug 31112: (QA follow-up) Restore check to avoid extra > processing > >We now count all holds for all patrons, we can still eject if we have more >holds than we do items > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Circulation.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 85fa276028..fd006ec2e1 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2959,6 +2959,8 @@ sub CanBookBeRenewed { > notforloan => 0, > -not => { itemnumber => $itemnumber } })->as_list; > >+ return ( 0, "on_reserve" ) if scalar @other_items < scalar @possible_holds; >+ > my %matched_items; > foreach my $possible_hold (@possible_holds) { > my $fillable = 0; >-- >2.30.2
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=139494">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31112
:
137826
|
137827
|
137828
|
137856
|
137857
|
137858
|
139492
|
139493
|
139494
|
139495
|
139622
|
139623
|
139729
|
139730
|
139731
|
139732
|
139733
|
139734
|
139735