Attachment 139499 Details for Bug 31343 – Bug 31343: (bug 31138 follow-up) Don't hide error

[patch] Bug 31343: (bug 31138 follow-up) Don't hide error

Bug-31343-bug-31138-follow-up-Dont-hide-error.patch (text/plain), 1.20 KB, created by Tomás Cohen Arazi (tcohen) on 2022-08-19 14:39:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-08-19 14:39:28 UTC

Size: 1.20 KB

patch

obsolete

>From e722a538695281bf67d984d5d9bfb41397fb5a77 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 12 Aug 2022 15:17:45 +0200
>Subject: [PATCH] Bug 31343: (bug 31138 follow-up) Don't hide error
>
>Some errors are not passing settings and so the error is hidden
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/js/datatables.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index 941ecbf351..d39bec0588 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -485,7 +485,7 @@ function filterDataTable( table, column, term ){
> }
> 
> jQuery.fn.dataTable.ext.errMode = function(settings, note, message) {
>-    if ( settings.jqXHR ) {
>+    if ( settings && settings.jqXHR ) {
>         console.log("Got %s (%s)".format(settings.jqXHR.status, settings.jqXHR.statusText));
>         alert(__("Something went wrong when loading the table.\n%s: %s").format(settings.jqXHR.status, settings.jqXHR.statusText));
>     } else {
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 31343: 139048 | 139049 | 139053 | 139054 | 139499 | 139500