Attachment 139500 Details for Bug 31343 – Bug 31343: Prevent two nodes #holdscr on waiting reserves

[patch] Bug 31343: Prevent two nodes #holdscr on waiting reserves

Bug-31343-Prevent-two-nodes-holdscr-on-waiting-res.patch (text/plain), 1.78 KB, created by Tomás Cohen Arazi (tcohen) on 2022-08-19 14:39:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-08-19 14:39:44 UTC

Size: 1.78 KB

patch

obsolete

>From 0b9a82541b5f77c5aa91050566af45422bbc0918 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 12 Aug 2022 15:19:10 +0200
>Subject: [PATCH] Bug 31343: Prevent two nodes #holdscr on waiting reserves
>
>Two nodes with id="holdscr" existed on this patch. I guess the table
>was not initiated properly before 31138 neither.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../intranet-tmpl/prog/en/modules/circ/waitingreserves.tt     | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
>index 4318918ee6..d0178bad40 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
>@@ -98,7 +98,7 @@
>                     </a>
>                 </li>
>                 <li role="presentation">
>-                    <a href="#holdscr" aria-controls="holdscr" role="tab" data-toggle="tab">
>+                    <a href="#holdscancelled" aria-controls="holdscancelled" role="tab" data-toggle="tab">
>                         Holds with cancellation requests: [% cancel_reqs_count | html %]
>                     </a>
>                 </li>
>@@ -139,7 +139,7 @@
>                 <div class="dialog message">No holds found.</div>
>             [% END %]
>         </div>
>-        <div role="tabpanel" class="tab-pane" id="holdscr">
>+        <div role="tabpanel" class="tab-pane" id="holdscancelled">
>             [% IF cancel_reqs_count %]
>                 [% INCLUDE waiting_holds.inc select_column='1' table_name='holdscr' reserveloop=cancel_reqs tab='holdscr' %]
>             [% ELSE %]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 31343: 139048 | 139049 | 139053 | 139054 | 139499 | 139500