Attachment 139517 Details for Bug 27817 – Bug 27817: Use biblio-title include in some acquisitions pages

[patch] Bug 27817: Use biblio-title include in some acquisitions pages

Bug-27817-Use-biblio-title-include-in-some-acquisi.patch (text/plain), 5.91 KB, created by Owen Leonard on 2022-08-19 18:42:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2022-08-19 18:42:59 UTC

Size: 5.91 KB

patch

obsolete

>From 26bcef3c5676367ac4259fd544ed02d5c172b2d5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 29 Mar 2021 14:57:22 +0000
>Subject: [PATCH] Bug 27817: Use biblio-title include in some acquisitions
> pages
>
>This patch adds the use of the biblio-title include in acquisitions
>templates which get the right data from their corresponding scripts.
>
>To test, apply the patch and test these Acquisitions pages to confirm
>that titles with 245$b, 245$h, etc, show all the correct information.
>
>- Acquisitions -> Vendor -> Basket
>- Acquisitions -> Vendor -> Uncertain prices
>- Acquisitions -> Invoices -> Invoice
>- Acquisitions -> Invoices -> Invoice -> View an invoice which has an
> already-received bibliographic record.
> - Go to receipt page -> Already received.
> -- The "Pending orders" table is unmodified because I wasn't sure
> how to use the biblio-title include in an AJAX DataTable.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 +++---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 2 +-
> .../intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 6 +++++-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 3 ++-
> .../intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt | 2 +-
> 5 files changed, 12 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 9d2687881d..598b674e34 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -528,9 +528,9 @@
> <td>
> 
> [% IF ( books_loo.order_received ) %] (received)[% END %]
>- [%- IF books_loo.title %]
>- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% books_loo.biblionumber | uri %]">[% books_loo.title | html %]</a>[% IF books_loo.author %] by [% books_loo.author | html %][% END -%]
>- [%- ELSE -%]
>+ [% IF books_loo.title %]
>+ [% INCLUDE 'biblio-title.inc' biblio=books_loo link = 1 %] [% IF books_loo.author %] by [% books_loo.author | html %][% END %]
>+ [% ELSE %]
> Deleted bibliographic record, can't find title 
> [%- END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>index fbaa3fa439..5614d5c692 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>@@ -364,7 +364,7 @@
> <tr>
> <td>
> [% IF order.biblionumber %]
>- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% order.biblionumber | uri %]">[% order.title | html %]</a>
>+ [% INCLUDE 'biblio-title.inc' biblio=order link = 1 %]
> [% IF ( order.author ) %]
> by [% order.author | html %]
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>index 80a1d9da65..a91fd6751c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>@@ -53,7 +53,11 @@
> 
> <fieldset class="rows">
> <legend>Catalog details</legend>
>- <ol><li>Title: [% order.biblio.title | html %]</li>
>+ <ol>
>+ <li>
>+ Title: 
>+ [% INCLUDE 'biblio-title.inc' biblio=order.biblio link = 1 %]
>+ </li>
> <li> Author: 
> [% order.biblio.author | html %]</li>
> <li>Copyright: 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>index eb3ea035ae..4e4c257477 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>@@ -227,7 +227,8 @@
> 0
> [% END %]
> </td>
>- <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% order.biblionumber | uri %]">[% order.title | html %]</a>
>+ <td>
>+ [% INCLUDE 'biblio-title.inc' biblio=order link = 1 %]
> [% IF ( order.author ) %] / [% order.author | html %][% END %]
> [% IF ( order.isbn ) %] - [% order.isbn | html %][% END %]
> [% IF ( order.publishercode ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>index 598e62dff6..e893def0de 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>@@ -116,7 +116,7 @@
> <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% uncertainpriceorder.basketno | uri %]">[% uncertainpriceorder.basketname | html %]</a>
> </td>
> 	 <td>
>- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% uncertainpriceorder.biblionumber | uri %]">[% uncertainpriceorder.title | html %]</a>
>+ [% INCLUDE 'biblio-title.inc' biblio=uncertainpriceorder link = 1 %]
> [% IF ( uncertainpriceorder.author ) %] by [% uncertainpriceorder.author | html %][% END %]
> [% IF ( uncertainpriceorder.publishercode ) %]
> Publisher: [% uncertainpriceorder.publishercode | html %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27817: 118969 | 126323 | 130899 | 130900 | 130901 | 139517 | 139564 | 139679 | 140734