Attachment 139533 Details for Bug 31390 – Bug 31390: Remove noisy warns in C4::Templates

[patch] Bug 31390: Remove noisy warns in C4::Templates

Bug-31390-Remove-noisy-warns-in-C4Templates.patch (text/plain), 1.49 KB, created by Fridolin Somers on 2022-08-20 07:37:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2022-08-20 07:37:36 UTC

Size: 1.49 KB

patch

obsolete

>From 959de4f58d2801c44c5d2d2a76d1ba7ecfff809e Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 18 Aug 2022 01:14:03 +0000
>Subject: [PATCH] Bug 31390: Remove noisy warns in C4::Templates
>
>This patch removes two noisy warnings from C4::Templates
>
>0) Apply patch and koha-plack --restart kohadev
>1) Go to http://localhost:8081/
>2) Note no warnings in /var/log/koha/kohadev/plack-intranet-error.log
>3) Go to http://localhost:8080/
>3) Note no warnings in /var/log/koha/kohadev/plack-opac-error.log
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
>---
> C4/Templates.pm | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/C4/Templates.pm b/C4/Templates.pm
>index 789495f3fa..dd54a6e3f4 100644
>--- a/C4/Templates.pm
>+++ b/C4/Templates.pm
>@@ -213,7 +213,6 @@ sub badtemplatecheck {
> 
> sub gettemplate {
>     my ( $tmplbase, $interface, $query ) = @_;
>-    ($query) or warn "no query in gettemplate";
>     my ($htdocs, $theme, $lang, $filename)
>        =  _get_template_file($tmplbase, $interface, $query);
>     badtemplatecheck( $filename ); # single trip for bad templates
>@@ -273,7 +272,6 @@ the use case where the DB is not populated already when rewriting/fixing.
> 
> sub themelanguage {
>     my ($htdocs, $tmpl, $interface, $query) = @_;
>-    ($query) or warn "no query in themelanguage";
> 
>     # Select a language based on cookie, syspref available languages & browser
>     my $lang = C4::Languages::getlanguage($query);
>-- 
>2.35.4

Actions: View | Diff | Splinter Review

Attachments on bug 31390: 139310 | 139397 | 139533