Attachment 139534 Details for Bug 31387 – Bug 31387: Fix othernames required label

[patch] Bug 31387: Fix othernames required label

Bug-31387-Fix-othernames-required-label.patch (text/plain), 1.94 KB, created by Fridolin Somers on 2022-08-20 07:43:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2022-08-20 07:43:33 UTC

Size: 1.94 KB

patch

obsolete

>From 0086c685b5d55082d7997bac20069a54e22d45f4 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 17 Aug 2022 17:09:44 +0000
>Subject: [PATCH] Bug 31387: Fix othernames required label
>
>1. Mark othernames as required via PatronSelfRegistrationBorrowerMandatoryField
>2. Go to the self-reg form, the field is required but the span that makes it look required stays hidden. (<div class="required_label required">Required</div>)
>3. Mark initials as required via PatronSelfRegistrationBorrowerMandatoryField.
>4. Now the label_required field appears for othernames in the self ref form
>5. Apply patch
>6. Try again, the label should now properly show when othernames is marked as required
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index dec7e2f7f6..a0e19b2ad0 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -376,7 +376,7 @@
>                                                 <label for="borrower_othernames" class="[% required.othernames | html %]">Other names:</label>
> 
>                                                 <input type="text" id="borrower_othernames" name="borrower_othernames" value="[% borrower.othernames | html %]" class="[% required.othernames | html %]" />
>-                                                <div class="required_label [% required.initials | html %]">Required</div>
>+                                                <div class="required_label [% required.othernames | html %]">Required</div>
>                                             </li>
>                                         [% END %]
> 
>-- 
>2.35.4

Actions: View | Diff | Splinter Review

Attachments on bug 31387: 139300 | 139306 | 139534