Attachment 139562 Details for Bug 31419 – Bug 31419: Add accesskeys for modals

[patch] Bug 31419: Add accesskeys for modals

Bug-31419-Add-accesskeys-for-modals.patch (text/plain), 5.37 KB, created by Katrin Fischer on 2022-08-21 21:52:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-08-21 21:52:23 UTC

Size: 5.37 KB

patch

obsolete

>From 7b8a2d198954932c5bc5a7dbf9e847c363edfdfe Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 19 Aug 2022 10:04:56 +0000
>Subject: [PATCH] Bug 31419: Add accesskeys for modals
>
>This patch simply adds accesskey elements to the buttons, and changes an icon to be
>consistent with bug 26626
>
>For tips on how to access the accesskeys:
>https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey
>
>To test:
>1 - Generate a recall
>2 - Fill it/check in
>3 - Note modal now has hints "Confirm (Y)"
>4 - Test with Y,P,I keys (may need to recreate recalls)
>5 - Confirm the recall and test waiting recall modal too
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/circ/returns.tt           | 28 +++++++++----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index ff5158e9e7..ec3cb009f3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -941,18 +941,18 @@
> 
>                                                 <div class="modal-footer">
>                                                     [% IF ( transfertodo ) %]
>-                                                        <button type="submit" class="btn btn-default approve">
>-                                                            <i class="fa fa-check"></i> Confirm recall and transfer
>+                                                        <button type="submit" class="btn btn-default approve" accesskey="Y">
>+                                                            <i class="fa fa-check"></i> Confirm recall and transfer (Y)
>                                                         </button>
>-                                                        <button type="button" class="btn btn-default print-recall">
>-                                                            <i class="fa fa-print"></i> Print slip, transfer, and confirm
>+                                                        <button type="button" class="btn btn-default print-recall" accesskey="P">
>+                                                            <i class="fa fa-print"></i> Print slip, transfer, and confirm (P)
>                                                         </button>
>                                                     [% ELSE %]
>-                                                        <button type="submit" class="btn btn-default approve">
>-                                                            <i class="fa fa-check"></i> Confirm recall
>+                                                        <button type="submit" class="btn btn-default approve" accesskey="Y">
>+                                                            <i class="fa fa-check"></i> Confirm recall (Y)
>                                                         </button>
>-                                                        <button type="button" class="btn btn-default print-recall">
>-                                                            <i class="fa fa-print"></i> Print slip and confirm
>+                                                        <button type="button" class="btn btn-default print-recall" accesskey="P">
>+                                                            <i class="fa fa-print"></i> Print slip and confirm (P)
>                                                         </button>
>                                                     [% END %]
> 
>@@ -1041,15 +1041,15 @@
>                                                 </div>
> 
>                                                 <div class="modal-footer">
>-                                                    <button type="submit" class="btn btn-default approve">
>-                                                        <i class="fa fa-check"></i> Confirm recall
>+                                                    <button type="submit" class="btn btn-default approve" accesskey="Y">
>+                                                        <i class="fa fa-check"></i> Confirm recall (Y)
>                                                     </button>
>-                                                    <button type="button" class="btn btn-default print-recall">
>-                                                        <i class="fa fa-print"></i> Print slip and confirm
>+                                                    <button type="button" class="btn btn-default print-recall" accesskey="P">
>+                                                        <i class="fa fa-print"></i> Print slip and confirm (P)
>                                                     </button>
> 
>-                                                    <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny">
>-                                                        <i class="fa fa-times"></i> Ignore
>+                                                    <button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny" accesskey="I">
>+                                                        <i class="fa fa-remove"></i> Ignore (I)
>                                                     </button>
>                                                 </div> 
>                                             </form> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31419: 139473 | 139562 | 140957