Bugzilla – Attachment 139605 Details for
Bug 30718
Use flatpickr's altInput option everywhere
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30718: (follow-up) index_records is called more times than we thought
Bug-30718-follow-up-indexrecords-is-called-more-ti.patch (text/plain), 1.60 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-08-22 14:20:22 UTC
(
hide
)
Description:
Bug 30718: (follow-up) index_records is called more times than we thought
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-08-22 14:20:22 UTC
Size:
1.60 KB
patch
obsolete
>From 35165e5f13ec11a62dea7f6b129f7f07c7ecb7f4 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 22 Aug 2022 11:19:27 -0300 >Subject: [PATCH] Bug 30718: (follow-up) index_records is called more times > than we thought > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Koha/SearchEngine/Indexer.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/SearchEngine/Indexer.t b/t/db_dependent/Koha/SearchEngine/Indexer.t >index dc885e1153..4bb2fdf1f8 100755 >--- a/t/db_dependent/Koha/SearchEngine/Indexer.t >+++ b/t/db_dependent/Koha/SearchEngine/Indexer.t >@@ -223,10 +223,10 @@ subtest 'Test indexer calls' => sub { > > warnings_are{ > ModItemTransfer( $item->itemnumber, $item2->homebranch, $item->homebranch,'Manual'); >- } [$engine,"Koha::Item"], "index_records is called for $engine when calling ModItemTransfer"; >+ } [$engine,"Koha::Item",$engine,"Koha::Item"], "index_records is called twice for $engine when calling ModItemTransfer"; > warnings_are{ >- ModItemTransfer( $item->itemnumber, $item->homebranch, $item2->homebranch,'Manual',{skip_record_index=>1}); >- } undef, "index_records is not called for $engine when calling ModItemTransfer with skip_record_index"; >+ ModItemTransfer( $item->itemnumber, $item->homebranch, $item2->homebranch,'Manual',{ skip_record_index => 1 }); >+ } [$engine,"Koha::Item"], "index_records is called once for $engine when calling ModItemTransfer with skip_record_index"; > > warnings_are{ > $item->delete(); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30718
:
135487
|
137516
|
137707
|
137715
|
137803
|
137804
|
137805
|
137806
|
137807
|
137868
|
137869
|
138644
|
138645
|
138646
|
138647
|
138648
|
138649
|
138650
|
138651
|
138652
|
138658
|
138659
|
138748
|
138749
|
138750
|
138751
|
138752
|
138753
|
138754
|
138755
|
138756
|
138757
|
138758
|
138879
|
138980
|
139033
|
139073
|
139074
|
139075
|
139076
|
139077
|
139078
|
139079
|
139080
|
139081
|
139082
|
139083
|
139084
|
139085
|
139453
|
139454
|
139455
|
139456
|
139457
|
139458
|
139459
|
139460
|
139461
|
139462
|
139463
|
139464
|
139465
|
139466
|
139467
|
139468
|
139490
| 139605 |
143175