Bugzilla – Attachment 139613 Details for
Bug 29955
Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29955: Fix method import issues
Bug-29955-Fix-method-import-issues.patch (text/plain), 2.13 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-08-22 16:14:45 UTC
(
hide
)
Description:
Bug 29955: Fix method import issues
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-08-22 16:14:45 UTC
Size:
2.13 KB
patch
obsolete
>From 7fcda17eabba1abedbc4046c9997c5cc8fd6d15b Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 22 Aug 2022 13:06:14 -0300 >Subject: [PATCH] Bug 29955: Fix method import issues > >This patch fixes this: > >$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t >t/db_dependent/Utils/Datatables_Virtualshelves.t .. 2/13 Use of inherited AUTOLOAD for non-method Koha::Virtualshelf::haspermission() is no longer allowed at /kohadevbox/koha/Koha/Virtualshelf.pm line 248. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Virtualshelf.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Virtualshelf.pm b/Koha/Virtualshelf.pm >index 382506bb28..605916ef45 100644 >--- a/Koha/Virtualshelf.pm >+++ b/Koha/Virtualshelf.pm >@@ -18,7 +18,7 @@ package Koha::Virtualshelf; > use Modern::Perl; > > >-use C4::Auth qw( haspermission ); >+use C4::Auth; > > use Koha::Patrons; > use Koha::Database; >@@ -234,7 +234,7 @@ sub can_be_deleted { > > my $patron = Koha::Patrons->find( $borrowernumber ) or return 0; > >- return 1 if $self->is_public and haspermission( $patron->userid, { lists => 'delete_public_lists' } ); >+ return 1 if $self->is_public and C4::Auth::haspermission( $patron->userid, { lists => 'delete_public_lists' } ); > > return 0; > } >@@ -246,7 +246,7 @@ sub can_be_managed { > > my $patron = Koha::Patrons->find( $borrowernumber ) or return 0; > return 1 >- if $self->is_public and haspermission( $patron->userid, { lists => 'edit_public_lists' } ); >+ if $self->is_public and C4::Auth::haspermission( $patron->userid, { lists => 'edit_public_lists' } ); > return 0; > } > >@@ -311,7 +311,7 @@ sub cannot_be_transferred { > if( $self->public ) { > my $by_patron = Koha::Patrons->find($by); > return 'unauthorized_transfer' >- if !$by_patron || !haspermission( $by_patron->userid, { lists => 'edit_public_lists' }); >+ if !$by_patron || !C4::Auth::haspermission( $by_patron->userid, { lists => 'edit_public_lists' }); > } else { > return 'unauthorized_transfer' if !$self->can_be_managed($by); > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29955
:
129856
|
135436
|
137797
|
139487
|
139518
| 139613