Bugzilla – Attachment 139657 Details for
Bug 24295
C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24295: Remove GetTransfers from opac-detail.pl
Bug-24295-Remove-GetTransfers-from-opac-detailpl.patch (text/plain), 2.25 KB, created by
Martin Renvoize (ashimema)
on 2022-08-23 11:23:01 UTC
(
hide
)
Description:
Bug 24295: Remove GetTransfers from opac-detail.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-08-23 11:23:01 UTC
Size:
2.25 KB
patch
obsolete
>From 254546b6a99435eb56bf37b3d19c3c2de1cd1694 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 15 Mar 2021 16:02:34 +0000 >Subject: [PATCH] Bug 24295: Remove GetTransfers from opac-detail.pl >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch replaces the call to GetTransfers in opac-detail with the >get_transfer method available from the Koha::Item object > >Test plan >1/ Trigger the transfer of the item >2/ Check the opac-detail page for the display of the current transfer > status >3/ Apply patch >4/ Repeat step 2 > >JK: Remove unneeded string formatting for transfertwhen as it's done > on the template toolkit side already with $KohaDates > >Rebased-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > opac/opac-detail.pl | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 1c5e7949ab..cd68ff83fa 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -45,7 +45,6 @@ use C4::Biblio qw( > GetMarcSubjects > GetMarcUrls > ); >-use C4::Circulation qw( GetTransfers ); > use C4::Tags qw( get_tags ); > use C4::XISBN qw( get_xisbns ); > use C4::External::Amazon qw( get_amazon_tld ); >@@ -734,12 +733,11 @@ else { > if ( $reserve_status eq "Waiting" ) { $item_info->{'waiting'} = 1; } > if ( $reserve_status eq "Reserved" ) { $item_info->{'onhold'} = 1; } > >- my ( $transfertwhen, $transfertfrom, $transfertto ) = >- GetTransfers( $item->itemnumber ); >- if ( defined($transfertwhen) && $transfertwhen ne '' ) { >- $item_info->{transfertwhen} = $transfertwhen; >- $item_info->{transfertfrom} = $transfertfrom; >- $item_info->{transfertto} = $transfertto; >+ my $transfer = $item->get_transfer; >+ if ( $transfer && $transfer->in_transit ) { >+ $item_info->{transfertwhen} = $transfer->datesent; >+ $item_info->{transfertfrom} = $transfer->frombranch; >+ $item_info->{transfertto} = $transfer->tobranch; > } > > if ( C4::Context->preference('OPACAcquisitionDetails') ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24295
:
118242
|
118243
|
118244
|
118245
|
118246
|
118247
|
118248
|
118249
|
118250
|
118287
|
118295
|
118296
|
118297
|
118298
|
118299
|
118300
|
118301
|
118302
|
118303
|
118304
|
118305
|
118306
|
118307
|
118308
|
118309
|
118310
|
119854
|
119855
|
119856
|
119857
|
119858
|
119859
|
119860
|
119861
|
119862
|
119863
|
119864
|
119866
|
119867
|
127465
|
127466
|
127467
|
127468
|
127469
|
127470
|
127471
|
127472
|
127473
|
127474
|
127475
|
127476
|
127477
|
130430
|
130431
|
130432
|
130433
|
130434
|
130435
|
130436
|
130437
|
130438
|
130439
|
130440
|
130441
|
130442
|
139546
|
139547
|
139548
|
139549
|
139550
|
139551
|
139552
|
139553
|
139554
|
139555
|
139556
|
139557
|
139558
|
139655
|
139656
| 139657 |
139658
|
139659
|
139660
|
139661
|
139662
|
139663
|
139664
|
139665
|
139666
|
139667