Bugzilla – Attachment 139770 Details for
Bug 23681
Make patron restrictions user definable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23681: Add modify_patron_restrictions permission
Bug-23681-Add-modifypatronrestrictions-permission.patch (text/plain), 5.37 KB, created by
Martin Renvoize (ashimema)
on 2022-08-25 11:36:38 UTC
(
hide
)
Description:
Bug 23681: Add modify_patron_restrictions permission
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-08-25 11:36:38 UTC
Size:
5.37 KB
patch
obsolete
>From a81512072cd0a83dce3864ec51c0832db3032ada Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Tue, 1 Oct 2019 16:03:58 +0100 >Subject: [PATCH] Bug 23681: Add modify_patron_restrictions permission > >This patch adds a new "modify_patron_restrictions" permission > >Sponsored-by: Loughborough University >Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > .../bug_23681_add_debarment_types.perl | 16 ++++++++-------- > ...3681_add_manage_patron_restrictions_perm.perl | 9 +++++++++ > .../data/mysql/mandatory/userpermissions.sql | 1 + > .../prog/en/includes/permissions.inc | 5 +++++ > .../prog/en/modules/admin/admin-home.tt | 4 ++++ > 5 files changed, 27 insertions(+), 8 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_23681_add_manage_patron_restrictions_perm.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_23681_add_debarment_types.perl b/installer/data/mysql/atomicupdate/bug_23681_add_debarment_types.perl >index 4fc862c954..0050b230eb 100644 >--- a/installer/data/mysql/atomicupdate/bug_23681_add_debarment_types.perl >+++ b/installer/data/mysql/atomicupdate/bug_23681_add_debarment_types.perl >@@ -18,15 +18,15 @@ if ( CheckVersion( $DBversion ) ) { > ('SUSPENSION', 'Suspension', 1, 0), > ('DISCHARGE', 'Discharge', 1, 0); > |); >+ $dbh->do( q| >+ ALTER TABLE borrower_debarments >+ MODIFY COLUMN type varchar(50) NOT NULL >+ | ); >+ $dbh->do( q| >+ ALTER TABLE borrower_debarments >+ ADD CONSTRAINT borrower_debarments_ibfk_2 FOREIGN KEY (type) REFERENCES debarment_types(code) ON DELETE NO ACTION ON UPDATE CASCADE; >+ | ); > } >- $dbh->do( q| >- ALTER TABLE borrower_debarments >- MODIFY COLUMN type varchar(50) NOT NULL >- | ); >- $dbh->do( q| >- ALTER TABLE borrower_debarments >- ADD CONSTRAINT borrower_debarments_ibfk_2 FOREIGN KEY (type) REFERENCES debarment_types(code) ON DELETE NO ACTION ON UPDATE CASCADE; >- | ); > > SetVersion( $DBversion ); > print "Upgrade to $DBversion done (Bug 23681 - Add debarment_types)\n"; >diff --git a/installer/data/mysql/atomicupdate/bug_23681_add_manage_patron_restrictions_perm.perl b/installer/data/mysql/atomicupdate/bug_23681_add_manage_patron_restrictions_perm.perl >new file mode 100644 >index 0000000000..283791ba8a >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_23681_add_manage_patron_restrictions_perm.perl >@@ -0,0 +1,9 @@ >+$DBversion = 'XXX'; >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do(q{ >+ INSERT IGNORE INTO permissions (module_bit, code, description) VALUES >+ ( 3, 'manage_patron_restrictions', 'Manage patron restrictions') >+ }); >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 23681 - Add manage_patron_restrictions_permission)\n"; >+} >diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql >index 612d17233f..a291f6dc6b 100644 >--- a/installer/data/mysql/mandatory/userpermissions.sql >+++ b/installer/data/mysql/mandatory/userpermissions.sql >@@ -20,6 +20,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES > ( 3, 'manage_item_circ_alerts', 'Manage item circulation alerts'), > ( 3, 'manage_cash_registers', 'Add and remove cash registers'), > ( 3, 'manage_cities', 'Manage cities and towns'), >+ ( 3, 'manage_patron_restrictions', 'Manage patron restrictions'), > ( 3, 'manage_marc_frameworks', 'Manage MARC bibliographic and authority frameworks'), > ( 3, 'manage_classifications', 'Manage classification sources'), > ( 3, 'manage_matching_rules', 'Manage record matching rules'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >index bb635165d1..dc1c309bba 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >@@ -163,6 +163,11 @@ > Manage patron categories > </span> > <span class="permissioncode">([% name | html %])</span> >+ [%- CASE 'manage_patron_restrictions' -%] >+ <span class="sub_permission manage_patron_restrictions_subpermission"> >+ Manage patron restrictions >+ </span> >+ <span class="permissioncode">([% name | html %])</span> > [%- CASE 'manage_patron_attributes' -%] > <span class="sub_permission manage_patron_attributes_subpermission"> > Manage extended patron attributes >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >index 0a77a06495..076dc0729c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >@@ -123,6 +123,10 @@ > <dt><a href="/cgi-bin/koha/admin/curbside_pickup.pl">Curbside pickup</a></dt> > <dd>Configure curbside pickup for libraries</dd> > [% END %] >+ [% IF ( CAN_user_parameters_manage_patron_restrictions ) %] >+ <dt><a href="/cgi-bin/koha/admin/restrictions.pl">Patron restrictions</a></dt> >+ <dd>Define patron restrictions.</dd> >+ [% END %] > </dl> > [% END %] > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23681
:
93769
|
93770
|
93771
|
93772
|
93773
|
93774
|
93775
|
93776
|
93777
|
93778
|
93779
|
93780
|
93781
|
93782
|
93783
|
93784
|
93785
|
93786
|
94862
|
94863
|
94864
|
94865
|
94866
|
94867
|
94868
|
94869
|
94870
|
94896
|
94897
|
94898
|
94899
|
94900
|
94901
|
94902
|
94903
|
94904
|
95148
|
95255
|
95256
|
95257
|
95258
|
95259
|
95260
|
95261
|
95262
|
95263
|
95264
|
99893
|
99894
|
99895
|
99896
|
99897
|
99898
|
99899
|
99900
|
99901
|
99902
|
130373
|
130374
|
130375
|
130376
|
130377
|
130378
|
130379
|
130380
|
130381
|
130382
|
130383
|
130384
|
132302
|
132303
|
132304
|
132305
|
132306
|
132307
|
132308
|
132309
|
132310
|
132311
|
132312
|
132313
|
132314
|
132315
|
132316
|
132318
|
132319
|
132320
|
134512
|
134513
|
134514
|
134515
|
134516
|
134517
|
134518
|
134519
|
134520
|
134521
|
134522
|
134523
|
134524
|
134525
|
134526
|
134527
|
134528
|
134529
|
134580
|
134581
|
134582
|
134583
|
134584
|
134585
|
134586
|
134587
|
134588
|
134589
|
134590
|
134591
|
134592
|
134593
|
134594
|
134595
|
134596
|
134597
|
134598
|
134599
|
134600
|
134601
|
134602
|
134684
|
134685
|
134686
|
134687
|
134688
|
134689
|
134690
|
134691
|
134692
|
134693
|
134694
|
134696
|
134697
|
134698
|
134699
|
134700
|
134701
|
134702
|
134703
|
134704
|
134705
|
134706
|
134707
|
134708
|
136716
|
136717
|
136718
|
136719
|
136720
|
136721
|
136722
|
136723
|
136724
|
136725
|
136726
|
136727
|
136728
|
136729
|
136730
|
136731
|
136732
|
136733
|
136734
|
136735
|
136736
|
136737
|
136738
|
136739
|
137066
|
137067
|
137068
|
137069
|
137070
|
137071
|
137072
|
137073
|
137074
|
137075
|
137076
|
137077
|
137078
|
137079
|
137080
|
137081
|
137082
|
137083
|
137084
|
137085
|
137086
|
137087
|
137088
|
137089
|
137090
|
137091
|
137092
|
137093
|
137094
|
137102
|
137103
|
137104
|
137105
|
137106
|
137107
|
137108
|
137109
|
137110
|
137111
|
137112
|
137113
|
137114
|
137115
|
137116
|
137117
|
137118
|
137119
|
137120
|
137121
|
137122
|
137123
|
137124
|
137125
|
137126
|
137127
|
137128
|
137129
|
137130
|
139250
|
139251
|
139252
|
139253
|
139254
|
139255
|
139256
|
139257
|
139258
|
139259
|
139260
|
139261
|
139262
|
139263
|
139264
|
139265
|
139266
|
139267
|
139268
|
139269
|
139270
|
139271
|
139272
|
139273
|
139509
|
139512
|
139649
|
139717
|
139768
|
139769
| 139770 |
139771
|
139772
|
139773
|
139774
|
139775
|
139776
|
139777
|
139778
|
139779
|
139780
|
139781
|
139782
|
139783
|
139784
|
139785
|
139786
|
139787
|
139788
|
139789
|
139790
|
139791
|
139792
|
139793
|
139794
|
139795