Bugzilla – Attachment 139810 Details for
Bug 31466
t/00-check-atomic-updates.t always fails if atomic update exists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31466: Fix t/00-check-atomic-updates.t to pass if atomic updates
Bug-31466-Fix-t00-check-atomic-updatest-to-pass-if.patch (text/plain), 1.33 KB, created by
Aleisha Amohia
on 2022-08-25 23:30:50 UTC
(
hide
)
Description:
Bug 31466: Fix t/00-check-atomic-updates.t to pass if atomic updates
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2022-08-25 23:30:50 UTC
Size:
1.33 KB
patch
obsolete
>From 30b72444fe71133333699d31692a152c3ff6d1da Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Fri, 26 Aug 2022 11:18:39 +1200 >Subject: [PATCH] Bug 31466: Fix t/00-check-atomic-updates.t to pass if atomic > updates > >The way the test was previously written, it would fail if atomic updates >matched the format /.*pl$/ . This is incorrect because atomic update >names should match the format /.*pl/. > >To test: >1) Run t/00-check-atomic-updates.t. Confirm test passes >2) Add an atomic update. Use the example from >https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file >3) Run t/00-check-atomic-updates.t. Confirm test fails >4) Apply patch and run t/00-check-atomic-updates.t. Test should pass! > >Sponsored-by: Catalyst IT >--- > t/00-check-atomic-updates.t | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/00-check-atomic-updates.t b/t/00-check-atomic-updates.t >index d9ad730815..1e1e556fb4 100755 >--- a/t/00-check-atomic-updates.t >+++ b/t/00-check-atomic-updates.t >@@ -31,7 +31,9 @@ sub wanted { > > foreach my $f (@files) { > next if $f eq 'skeleton.pl'; >- unlike( $f, qr/.*pl$/, "check for unhandled atomic updates: $f" ); >+ next if $f eq 'README'; >+ next if $f eq '.'; >+ like( $f, qr/.*pl$/, "check for unhandled atomic updates: $f" ); > } > > done_testing(); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31466
: 139810