Attachment 139817 Details for Bug 30262 – Bug 30262: Trim whitespace off tracklinks.pl URLs

[patch] Bug 30262: Trim whitespace off tracklinks.pl URLs

Bug-30262-Trim-whitespace-off-tracklinkspl-URLs.patch (text/plain), 1.68 KB, created by Magnus Enger on 2022-08-26 07:44:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2022-08-26 07:44:53 UTC

Size: 1.68 KB

patch

obsolete

>From c48b6b047418e4427d98cd92958cb9a12be9df74 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 10 Mar 2022 04:02:49 +0000
>Subject: [PATCH] Bug 30262: Trim whitespace off tracklinks.pl URLs
>
>This patch trims whitespace off tracklinks.pl URLs so that
>the URL is in the same format as the URLs returned by
>C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally.
>
>Test plan:
>0. Apply patch and koha-plack --restart kohadev
>1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29
>2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0
>3. Save record
>4. Change 'TrackClicks' syspref to 'Track'
>5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29
>6. Click on the online resource (eg
>http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20&biblionumber=29
>)
>7. Note you are redirected to https://koha-community.org
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>Added the link with a space at the end. Verified that without the
>patch, clickin on "Click here to access online" gives a 404. After
>applying the patch the redirect works as expected.
>---
> opac/tracklinks.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/opac/tracklinks.pl b/opac/tracklinks.pl
>index 8f8e0ddb78..2470359821 100755
>--- a/opac/tracklinks.pl
>+++ b/opac/tracklinks.pl
>@@ -33,6 +33,7 @@ my $cgi = CGI->new;
> my $uri = $cgi->param('uri') || '';
> my $biblionumber = $cgi->param('biblionumber');;
> my $itemnumber   = $cgi->param('itemnumber');
>+$uri =~ s/^\s+|\s+$//g if $uri; # trim
> 
> my $tracking_method = C4::Context->preference('TrackClicks');
> unless ( $tracking_method ) {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30262: 131534 | 139815 | 139817 | 139909